Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation's click events don't reach Lightbox/Fancybox #219

Closed
shaitanaa opened this issue Aug 15, 2013 · 9 comments
Closed

Annotation's click events don't reach Lightbox/Fancybox #219

shaitanaa opened this issue Aug 15, 2013 · 9 comments
Assignees
Milestone

Comments

@shaitanaa
Copy link

I'm not terribly good with jQuery so forgive me if this question is asinine, but I've been trying to get an annotation to work with Lightbox or Fancybox and neither will work. I've tested links that open with Lightbox elsewhere on the page and they're fine but trying to embed the link as an annotation in Reel just opens the image in a new tab instead of a popup. Any thoughts on what the problem might be?

@pisi
Copy link
Owner

pisi commented Aug 15, 2013

Can you show me?

@lifeinlightspeed
Copy link

Shaitanaa, I'm not sure about using Fancybox or Lightbox (I've used both) but here's an example of one using Colorbox:

http://www.luxurylifeshop.com/roxy-genuine-python-handbag/

(Click the links next to where it says 360 zoom)

Colorbox: http://www.jacklmoore.com/colorbox/

@shaitanaa
Copy link
Author

Ah, should have been more clear - I want Lightbox to launch from an annotated link within a Reel panorama. Lifeinlightspeed, I think the example you showed me is the other way around - a Reel panorama within a Lightbox popup.

Pisi, here's what I'm working on. If you scroll over to the right in the panorama you'll see a button that's supposed to show a zoomed in version of the part of the image it's on top of in a Lightbox popup. I have the same button outside of the annotation div underneath the panorama to show that Lightbox is working there. http://its.monmouth.edu/adasgupt/testing/swp/DiningRoom.html

@pisi
Copy link
Owner

pisi commented Aug 16, 2013

Oh, OK, I see. It looks like click event isn't emitted from the whole situation, hence the lightbox failure. In other words, a bug. Have the cure already, which I currently test. Thanks for pointing out this issue! It looks to have helped remove quite an awkward portion of the code :) Hold on for the patched code.

pisi added a commit that referenced this issue Aug 16, 2013
…to be more compatible with plugins relying on catching `click` on document level #219
pisi added a commit that referenced this issue Aug 16, 2013
…p.annotations` event, where it gets handled like a regular link. Also makes possible to test this. #219
@pisi
Copy link
Owner

pisi commented Aug 16, 2013

Now, I didn't add any extra examples yet, but meanwhile please try the code in gh-219-annotation-clicks branch. Replace your jquery.reel.js with this jquery.reel.js from the branch and the annotation link you use on your site should now open into the lightbox.

Please let me know, if that worked for you.

@ghost ghost assigned pisi Aug 16, 2013
@shaitanaa
Copy link
Author

Thank you so much! Good to know that I wasn't just making some obvious
mistake. I'll try it out first thing on Monday.

On Fri, Aug 16, 2013 at 4:49 PM, Petr Vostřel notifications@github.comwrote:

Now, I didn't add any extra examples yet, but meanwhile please try the
code in gh-219-annotation-clicks branchhttp://pisi/Reel/tree/gh-219-annotation-clicks.
Replace your jquery.reel.js with this _jquery.reel.js_http://pisi/Reel/raw/gh-219-annotation-clicks/jquery.reel.jsfrom the branch and the annotation link you use on your site should now
open into the lightbox.

Please let me know, if that worked for you.


Reply to this email directly or view it on GitHubhttps://github.com//issues/219#issuecomment-22793007
.

rupa dasgupta
http://www.rupadasgupta.com
http://www.anoctopusaday.com
http://www.antagonisticouture.com

@shaitanaa
Copy link
Author

Just tried it - worked perfectly. Thanks again!

@pisi
Copy link
Owner

pisi commented Aug 19, 2013

You're welcome :)

@pisi
Copy link
Owner

pisi commented Nov 5, 2013

Released today as part of v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants