Skip to content

Incompatible with jQuery 1.6 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pisi opened this issue May 8, 2011 · 1 comment
Closed

Incompatible with jQuery 1.6 #32

pisi opened this issue May 8, 2011 · 1 comment
Assignees
Labels
Milestone

Comments

@pisi
Copy link
Owner

pisi commented May 8, 2011

Reel has some features (indicator for example) missing in jQuery 1.6. Otherwise functionaly is OK.

@ghost ghost assigned pisi May 8, 2011
@pisi
Copy link
Owner Author

pisi commented May 8, 2011

Apparently the only thing that's seriously changed in 1.6 is that using className as a .attr param does no longer translate to class attribute like it does in 1.5.2 and below.

So instead of this:

{
  className: ...
}

using this should be sufficient to resolve all issues occuring:

{
  'class': ...
}

At least all tests suggest so far. It is used on several places in the code. Patch in a matter of hours.

@pisi pisi closed this as completed in 2bb1e89 May 8, 2011
pisi added a commit that referenced this issue May 8, 2011
* Promptly resolves sudden incompatibility with new jQuery 1.6 (GH-32).
* Enhanced test for by testing for CSS value equivalency rather for string equality (GH-33).
* `leader` tests Opera bug fixed (GH-34).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant