New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible both edges of non-looping panorama #4

Closed
pisi opened this Issue Apr 9, 2010 · 6 comments

Comments

Projects
None yet
2 participants
@pisi
Owner

pisi commented Apr 9, 2010

Greg Miernicki reported an issue with large dimensions stitched non-looping panorama. There seems to be no serious error in his HTML. The pan.jpg has dimensions of 1000x738 and pan-reel is 5276x738.

When removed frames and frame to see its frame one, one can see the both edges of the panorama and horizontal shift of background is 146.556px. Even when the background shift is corrected by hand to zero, when dragged, one moves in completely opposite direction again uncovering both edges.

Also setting frames doesn't seem to have any effect on the projection when using stitched panorama.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Apr 9, 2010

Owner

Greg's HTML:

    <html> 
        <head> 
            <script charset='utf-8' src='http://code.jquery.com/jquery-latest.min.js' type='text/javascript'></script> 
            <script charset='utf-8' src='reel-bundle.js' type='text/javascript'>    </script> 
            <style> 
            .panclass {
                width: 1000px; 
                height: 738px; 
                cursor: ew-resize; 
                border: 2px solid #000;
            }
            </style> 
        </head> 
        <body> 
            <img class="panclass" width="1000" height="738" id="pan" src="pan.jpg"> 
        </body> 
        <script> 
            $("#pan").reel({
                stitched:5276, indicator:20, frames:50, frame:33, saves:false, reversed:true, loops:false
            })
        </script> 
    </html>
Owner

pisi commented Apr 9, 2010

Greg's HTML:

    <html> 
        <head> 
            <script charset='utf-8' src='http://code.jquery.com/jquery-latest.min.js' type='text/javascript'></script> 
            <script charset='utf-8' src='reel-bundle.js' type='text/javascript'>    </script> 
            <style> 
            .panclass {
                width: 1000px; 
                height: 738px; 
                cursor: ew-resize; 
                border: 2px solid #000;
            }
            </style> 
        </head> 
        <body> 
            <img class="panclass" width="1000" height="738" id="pan" src="pan.jpg"> 
        </body> 
        <script> 
            $("#pan").reel({
                stitched:5276, indicator:20, frames:50, frame:33, saves:false, reversed:true, loops:false
            })
        </script> 
    </html>
@G-9999

This comment has been minimized.

Show comment
Hide comment
@G-9999

G-9999 Apr 9, 2010

Also, its more of an aesthetic preference, but the indicator icon on the bottom doesn't seem to follow the left/right scroll of the non-looping panaorama, but instead an arbitrary frame reference.

G-9999 commented Apr 9, 2010

Also, its more of an aesthetic preference, but the indicator icon on the bottom doesn't seem to follow the left/right scroll of the non-looping panaorama, but instead an arbitrary frame reference.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Apr 17, 2010

Owner

Greg, I've identified and fixed the issue. It now works as a charm :) I will merge it into master for Monday's 1.0.4 release. Then you can again grab the fixed reel-bundle from the homepage. Till then it's here:

http://github.com/pisi/Reel/tree/gh-4-patch

Enjoy! And again, thank you for reporting this issue. It helped :)

Owner

pisi commented Apr 17, 2010

Greg, I've identified and fixed the issue. It now works as a charm :) I will merge it into master for Monday's 1.0.4 release. Then you can again grab the fixed reel-bundle from the homepage. Till then it's here:

http://github.com/pisi/Reel/tree/gh-4-patch

Enjoy! And again, thank you for reporting this issue. It helped :)

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Apr 17, 2010

Owner

Also, the miscalculation was the cause for reversed indicator movement. It now follows the rotation of the scene. So if you reel to the far right (or left) of the non-looping panorama, you will find the indicator also far right (or left).

Owner

pisi commented Apr 17, 2010

Also, the miscalculation was the cause for reversed indicator movement. It now follows the rotation of the scene. So if you reel to the far right (or left) of the non-looping panorama, you will find the indicator also far right (or left).

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Apr 19, 2010

Owner

The made it to 1.0.4 master. I hope you are happy with it, Greg. If not, feel free to open new issue. Closing this one.

Owner

pisi commented Apr 19, 2010

The made it to 1.0.4 master. I hope you are happy with it, Greg. If not, feel free to open new issue. Closing this one.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Apr 24, 2010

Owner

Automated test for this issue has been added to the test suite:

http://jquery.vostrel.cz/reel/source/test/index.html?Issues (GH-4)

Owner

pisi commented Apr 24, 2010

Automated test for this issue has been added to the test suite:

http://jquery.vostrel.cz/reel/source/test/index.html?Issues (GH-4)

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment