Repository navigation
Visible both edges of non-looping panorama #4
Description
Activity
Greg's HTML:
<html> <head> <script charset='utf-8' src='http://code.jquery.com/jquery-latest.min.js' type='text/javascript'></script> <script charset='utf-8' src='reel-bundle.js' type='text/javascript'> </script> <style> .panclass { width: 1000px; height: 738px; cursor: ew-resize; border: 2px solid #000; } </style> </head> <body> <img class="panclass" width="1000" height="738" id="pan" src="pan.jpg"> </body> <script> $("#pan").reel({ stitched:5276, indicator:20, frames:50, frame:33, saves:false, reversed:true, loops:false }) </script> </html>
Greg, I've identified and fixed the issue. It now works as a charm :) I will merge it into master for Monday's 1.0.4 release. Then you can again grab the fixed reel-bundle from the homepage. Till then it's here:
http://github.com/pisi/Reel/tree/gh-4-patch
Enjoy! And again, thank you for reporting this issue. It helped :)
Also, the miscalculation was the cause for reversed indicator movement. It now follows the rotation of the scene. So if you reel to the far right (or left) of the non-looping panorama, you will find the indicator also far right (or left).
The made it to 1.0.4 master. I hope you are happy with it, Greg. If not, feel free to open new issue. Closing this one.
Automated test for this issue has been added to the test suite:
http://jquery.vostrel.cz/reel/source/test/index.html?Issues (GH-4)
Greg Miernicki reported an issue with large dimensions stitched non-looping panorama. There seems to be no serious error in his HTML. The pan.jpg has dimensions of 1000x738 and pan-reel is 5276x738.
When removed
framesandframeto see its frame one, one can see the both edges of the panorama and horizontal shift of background is 146.556px. Even when the background shift is corrected by hand to zero, when dragged, one moves in completely opposite direction again uncovering both edges.Also setting
framesdoesn't seem to have any effect on the projection when using stitched panorama.