New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`pan` event (renamed from `slide`) #51

Closed
unfalln opened this Issue Jul 25, 2011 · 4 comments

Comments

Projects
None yet
2 participants
@unfalln

unfalln commented Jul 25, 2011

When both jquery, reel and mootools are loaded onto the same page and the user attempts to slide the reel to the left or right with the mouse, this accidently triggers the mootools 'slide' event on the outer div, which causes the image to disappear like a raised curtain. If possible, could the 'slide' event be renamed to something a little less generic to counter this issue? Thanks!

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Jul 27, 2011

Owner

Oh, sorry to hear that. Didn't know about this conflict until now, thanks! I will sure rename the event. Once again I would say - it originaly was drag, but that was found to conflict in IE ;)

Now just find a proper name. It should best refer to some two-dimensional task (it carries along x and y arguments). It is reused twice in Reel (by mouse mouse and touch drag). Any ideas?

Owner

pisi commented Jul 27, 2011

Oh, sorry to hear that. Didn't know about this conflict until now, thanks! I will sure rename the event. Once again I would say - it originaly was drag, but that was found to conflict in IE ;)

Now just find a proper name. It should best refer to some two-dimensional task (it carries along x and y arguments). It is reused twice in Reel (by mouse mouse and touch drag). Any ideas?

@ghost ghost assigned pisi Jul 27, 2011

@unfalln

This comment has been minimized.

Show comment
Hide comment
@unfalln

unfalln Jul 27, 2011

Actually, in the copy I used on my site, I just renamed it to 'reelslide', but if it's a two-dimensional task my guess would be that it's something like a 'pan'. Also, given that this is primarily to show images from different angles, might it also be correct to use 'rotate'? Granted both of these words are again quite generic, perhaps namespacing them in some way such as 'reel.slide', 'reel-pan' or 'reel_rotate'? These are just suggestions, as I don't know too much about the standards involved with jQuery (not mentioning javascript in general) so implementation is well and truly up to you :)

unfalln commented Jul 27, 2011

Actually, in the copy I used on my site, I just renamed it to 'reelslide', but if it's a two-dimensional task my guess would be that it's something like a 'pan'. Also, given that this is primarily to show images from different angles, might it also be correct to use 'rotate'? Granted both of these words are again quite generic, perhaps namespacing them in some way such as 'reel.slide', 'reel-pan' or 'reel_rotate'? These are just suggestions, as I don't know too much about the standards involved with jQuery (not mentioning javascript in general) so implementation is well and truly up to you :)

@unfalln unfalln closed this Jul 27, 2011

@unfalln unfalln reopened this Jul 27, 2011

@unfalln unfalln closed this Jul 27, 2011

@unfalln unfalln reopened this Jul 27, 2011

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Nov 5, 2011

Owner

pan sounds just fine. @unfalln, please confirm the resolution of this conflict by testing the code from the development branch, which doesn't use slide anymore. Thanks!

Owner

pisi commented Nov 5, 2011

pan sounds just fine. @unfalln, please confirm the resolution of this conflict by testing the code from the development branch, which doesn't use slide anymore. Thanks!

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Dec 17, 2011

Owner

@pelister verified and confirmed resolution of this ticket in his comment in the #87. Thanks!

Owner

pisi commented Dec 17, 2011

@pelister verified and confirmed resolution of this ticket in his comment in the #87. Thanks!

@pisi pisi closed this Dec 17, 2011

pisi added a commit that referenced this issue Dec 30, 2011

1.2 ALPHA is out!
Just missing annotations examples - the'll be in the beta.

Changes:

* Non-`wheelable` Reels now allow scrolling of the page when wheeling above the Reel instance.
* New option `attr` allows to set custom attributes of the IMG tag (useful for re-using DOM nodes).
* Instances being re-instantiated now perform automatic teardown (GH-62).
* Proper image preload events unbinding on teardown (GH-64).
* Option `scrollable` can disable page scrolling (if needed) on touch devices.
* New event `"openingDone"` now announces the end of opening animation (GH-65).
* Internal event `slide` renamed to `pan` (GH-51).
* Actual frame number is manifested with a wrapper class name, e.g. `frame-8` (GH-69).
* Improved order of preloaded images gradually increasing fidelity of the image, thus the name `"fidelity"` and this mode is now default. The former order is designated `"linear". Preloading mode is chosen by new `preload` option accepting a mode name. (GH-10).
* Deprecated options `hotspot`, `tooltip` and `reversed` have been removed.
* Bare click on left/right half of the image steps the Reel one frame forward/back. Set `steppable` to false to disable. Comes with `"stepLeft"` and `"stepRight"` events (GH-20).
* Custom text/graphics can augment the frames using the brand new `annotations` feature (GH-36).
* New complementary `.unreel()` function to revert effects of `.reel()` on the DOM.
* Control event `play` now accepts optional `speed` parameter.
* Mouse cursor is now customizable with the new `cursor` option. The new failsafe cursor is now `"move"`.

pisi added a commit that referenced this issue Jul 16, 2012

Reel 1.2
========

Lovely new features:
* in-picture annotations
* new image preloading method
* frame by frame stepping
* new data change model
* full documentation
* jQuery 1.5+

New options:
* `annotations`, `attr`, `cursor`, `steppable`, improved `images`

New events:
* `stepLeft`, `stepRight`, `openingDone`, improved `play`

New methods:
* `.unreel()`, improved `.reel()`

Includes fixes for issues #10, #20, #36, #51, #62, #64, #65, #69, #103, #110, #111, #113, #115, #117, #122, #124, #125, #126

Enjoy!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment