From f3ae9aab17dd49856da12a419de082a7b8700ff7 Mon Sep 17 00:00:00 2001 From: TalIfargan Date: Mon, 31 Oct 2022 21:04:52 +0200 Subject: [PATCH 1/2] fixed loss computation for sg, hs --- gensim/models/word2vec_inner.pyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gensim/models/word2vec_inner.pyx b/gensim/models/word2vec_inner.pyx index ffdc908b5c..39d2496c7e 100755 --- a/gensim/models/word2vec_inner.pyx +++ b/gensim/models/word2vec_inner.pyx @@ -126,7 +126,7 @@ cdef void w2v_fast_sentence_sg_hs( if _compute_loss == 1: sgn = (-1)**word_code[b] # ch function: 0-> 1, 1 -> -1 - lprob = -1*sgn*f_dot + lprob = sgn*f_dot if lprob <= -MAX_EXP or lprob >= MAX_EXP: continue lprob = LOG_TABLE[((lprob + MAX_EXP) * (EXP_TABLE_SIZE / MAX_EXP / 2))] From 7c3e6d044811d1e47ec72a4c11496b6106a8877a Mon Sep 17 00:00:00 2001 From: TalIfargan Date: Tue, 1 Nov 2022 19:15:44 +0200 Subject: [PATCH 2/2] fixed loss computation for cbow, hs --- gensim/models/word2vec_inner.pyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gensim/models/word2vec_inner.pyx b/gensim/models/word2vec_inner.pyx index 39d2496c7e..3692e3e5b8 100755 --- a/gensim/models/word2vec_inner.pyx +++ b/gensim/models/word2vec_inner.pyx @@ -326,7 +326,7 @@ cdef void w2v_fast_sentence_cbow_hs( if _compute_loss == 1: sgn = (-1)**word_code[b] # ch function: 0-> 1, 1 -> -1 - lprob = -1*sgn*f_dot + lprob = sgn*f_dot if lprob <= -MAX_EXP or lprob >= MAX_EXP: continue lprob = LOG_TABLE[((lprob + MAX_EXP) * (EXP_TABLE_SIZE / MAX_EXP / 2))]