New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect loop in creating a user session, right after a SAML login #5

Open
sandorspruit opened this Issue Jan 9, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@sandorspruit

sandorspruit commented Jan 9, 2018

I am experimenting with LimeSurvey SAML authentication, based on the plugin. Everything seems to be working just fine, users gets created in the database etc. but Yii loses the identity of the user right after the login. In particular: Yii::app()->user->getId() returns nothing after the final redirect to AdminController.

This causes LimeSurvey to redirect back and forth, indefinitely, between the AdminController (application/controllers/AdminController) and the authentication action (application/controllers/admin/authentication), until my browser gives up.

@Shnoulle

This comment has been minimized.

Show comment
Hide comment
@Shnoulle

Shnoulle Jan 9, 2018

Remind to put your LimeSurvey version :) 3.0 maybe ?

Shnoulle commented Jan 9, 2018

Remind to put your LimeSurvey version :) 3.0 maybe ?

@sandorspruit

This comment has been minimized.

Show comment
Hide comment
@sandorspruit

sandorspruit Jan 9, 2018

Thanks for the heads-up :) I am on Lime 2.72.5+171121

sandorspruit commented Jan 9, 2018

Thanks for the heads-up :) I am on Lime 2.72.5+171121

@Shnoulle

This comment has been minimized.

Show comment
Hide comment
@Shnoulle

Shnoulle Jan 9, 2018

Did you try with deactivating CRSF ? #4 (comment)

Shnoulle commented Jan 9, 2018

Did you try with deactivating CRSF ? #4 (comment)

@sandorspruit

This comment has been minimized.

Show comment
Hide comment
@sandorspruit

sandorspruit Jan 10, 2018

Yes, that was one of the first things we tried. I noticed some small changes in the authentication code, after a recent comfort update, so I'll re-investigate soon to see where that leaves me.

sandorspruit commented Jan 10, 2018

Yes, that was one of the first things we tried. I noticed some small changes in the authentication code, after a recent comfort update, so I'll re-investigate soon to see where that leaves me.

@Shnoulle

This comment has been minimized.

Show comment
Hide comment
@Shnoulle

Shnoulle Jan 10, 2018

This is strange, because webserver plugin are not updated since a lot of time :/

Else : maybe move this part to init :

public function __construct(PluginManager $manager, $id) {

Shnoulle commented Jan 10, 2018

This is strange, because webserver plugin are not updated since a lot of time :/

Else : maybe move this part to init :

public function __construct(PluginManager $manager, $id) {

@sandorspruit

This comment has been minimized.

Show comment
Hide comment
@sandorspruit

sandorspruit Jan 26, 2018

I have already tried that. Now looking into the issue noted here:
https://simplesamlphp.org/docs/stable/simplesamlphp-sp#section_6 (last couple of lines in section 6)

sandorspruit commented Jan 26, 2018

I have already tried that. Now looking into the issue noted here:
https://simplesamlphp.org/docs/stable/simplesamlphp-sp#section_6 (last couple of lines in section 6)

@Frankniesten

This comment has been minimized.

Show comment
Hide comment
@Frankniesten

Frankniesten Feb 1, 2018

Maybe your session is lost. Try a different session storage method in simplesamlphp.

Frankniesten commented Feb 1, 2018

Maybe your session is lost. Try a different session storage method in simplesamlphp.

@maettle

This comment has been minimized.

Show comment
Hide comment
@maettle

maettle Sep 4, 2018

I've got the same problem. After klicking the SAML button I get redirected to ADFS, and after the successful login it sends me into a never ending loop (and i don't know where), FF says Redirect Error.
@sandorspruit did you solve this problem?

maettle commented Sep 4, 2018

I've got the same problem. After klicking the SAML button I get redirected to ADFS, and after the successful login it sends me into a never ending loop (and i don't know where), FF says Redirect Error.
@sandorspruit did you solve this problem?

@sandorspruit

This comment has been minimized.

Show comment
Hide comment
@sandorspruit

sandorspruit Sep 5, 2018

Nope. At some point it was working 95% but the session issue kept coming up. Tried changing the simplesaml session storage method but it just wouldn't go away.

sandorspruit commented Sep 5, 2018

Nope. At some point it was working 95% but the session issue kept coming up. Tried changing the simplesaml session storage method but it just wouldn't go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment