Use actual file names as cache keys #2

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants

It is more natural to use filenames as cache keys and allows to use same filenames under different subfolders.

+1

Contributor

dmathieu commented Oct 26, 2013

Here you go

Contributor

dmathieu commented Oct 28, 2013

Thank you @luckyjazzbo. Unfortunately, I can't merge this since there are conflicts.
Also, you changed quite a bit of things in your branch, making it difficult to see what's the exact subject of the commit.
Could you rebase your branch to include only the actual change?

@dmathieu dmathieu closed this in 82370ba Oct 29, 2013

Contributor

dmathieu commented Oct 29, 2013

@luckyjazzbo: I just pushed a cleaned version of your changes.
I didn't keep your removal of the window override, since it will prevent us from retrieving the views.
I also didn't keep your templates_dir configuration parameter, since it's redundant with module_name.

Thank you for your commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment