From e27e59309e9671cb3299bdcde057e36cb76870bb Mon Sep 17 00:00:00 2001 From: Geoffrey Spear Date: Wed, 12 Jun 2019 10:07:07 -0400 Subject: [PATCH] TR_J1: correctly report line metrics as "Total_Item_Requests" (Formerly reported as "FT Article Requests" for compatibility with Hermit ERM.) Report metric for COUNTER 5 will be set to None, as COUNTER 5 reports contain multiple metrics. --- pycounter/sushi5.py | 4 ++-- pycounter/test/counter5/test_sushi.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pycounter/sushi5.py b/pycounter/sushi5.py index 595c8e5..da56ec7 100644 --- a/pycounter/sushi5.py +++ b/pycounter/sushi5.py @@ -70,7 +70,7 @@ def raw_to_full(raw_report): report_type=header["Report_ID"], customer=header.get("Institution_Name", ""), institutional_identifier=header.get("Customer_ID", ""), - metric="FT Item Requests", # FIXME: this is for COUNTER4 compatibility + metric=None, # COUNTER 5 reports usually contain multiple metrics date_run=pendulum.parse(date_run) if date_run else datetime.datetime.now(), ) @@ -99,7 +99,7 @@ def raw_to_full(raw_report): platform=platform, publisher=publisher_name, period=report.period, - metric=report.metric, + metric="Total_Item_Requests", issn=identifiers["issn"], eissn=identifiers["eissn"], doi=identifiers["doi"], diff --git a/pycounter/test/counter5/test_sushi.py b/pycounter/test/counter5/test_sushi.py index 0cb1b64..d971a68 100644 --- a/pycounter/test/counter5/test_sushi.py +++ b/pycounter/test/counter5/test_sushi.py @@ -22,7 +22,7 @@ def test_data(sushi5_report): def test_metric(sushi5_report): publication = next(iter(sushi5_report)) metrics = [month[1] for month in publication] - assert metrics[0] == u"FT Item Requests" # FIXME: COUNTER4 compat kludge + assert metrics[0] == u"Total_Item_Requests" def test_doi(sushi5_report):