Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: pivotal-benchmark/roo
base: master
...
head fork: roo-rb/roo
compare: master
Checking mergeability… Don’t worry, you can still create the pull request.
This comparison is big! We’re only showing the most recent 250 commits
Commits on Mar 27, 2014
@Empact Empact Bump rspec version to > 2.14 e4e9044
@Empact Empact Tidy up Roo::Base#find, #find_by_row, #find_by_conditions. 1ccedab
@Empact Empact Only apply URI parsing if the path is a URI. Fixes #121.
Alternative fix to 268adb5.
f062bd2
@Empact Empact Fix error in test helper file_diff 56e2e61
@rui-castro rui-castro Added test for nil in Roo::Excelx#read_hyperlinks to avoid error "NoM…
…ethodError (undefined method `text' for nil:NilClass)"
75bc50a
Commits on Mar 28, 2014
@SheetJSDev SheetJSDev Fixing invalid test case
datetime.xml was changed in commit c9508fe, but excel 2011/2013 don't recognize the file as valid.
b1b8794
@Empact Empact Merge pull request #124 from SheetJSDev/patch-1
Fixing invalid test case
08c68c3
Commits on Mar 30, 2014
@rui-castro rui-castro Updated the XPATH query to "/xmlns:worksheet/xmlns:hyperlinks/xmlns:h…
…yperlink[id]" to avoid the previous error "NoMethodError (undefined method `text' for nil:NilClass)"
d69d198
Commits on Apr 28, 2014
@Empact Empact Merge pull request #123 from rui-castro/master
Fixes "NoMethodError (undefined method `text' for nil:NilClass)" issue when reading xlsx file (roo-rb#122)
a46611c
Commits on May 08, 2014
@mwmalinowski mwmalinowski Move .strip to after .pack in sanitize_value
Before:
" whitespace and unicode #{128.chr('UTF-8')} ".strip.unpack('U*').select {|b| b < 127}.pack('U*')
#=> "whitespace and unicode "
After:
" whitespace and unicode #{128.chr('UTF-8')} ".unpack('U*').select {|b| b < 127}.pack('U*').strip
#=> "whitespace and unicode"
4761c98
Commits on Jun 09, 2014
@Empact Empact Implement Excelx#comment? in terms of #comment 0fb90ec
@Empact Empact Disambiguate #open call in Excelx#extract_file. Fixes #125. 597482c
@Empact Empact Do some tidying up in Roo::Base. b131196
@Empact Empact Minor cleanup. 066e627
@Empact Empact Add a call for maintainers to the readme. 9e1b969
Commits on Jul 30, 2014
@DanMeakin DanMeakin Fix when opening spreadsheet with space in filename
URI::InvalidURIError is raised when attempting to open a spreadsheet with spaces in the filepath. This is caused by the behaviour of the URI package. This is fixed by encoding the filepath before calling URI.parse.
3c6b595
@simonoff simonoff Merge pull request #142 from DanMeakin/patch-1
Fix when opening spreadsheet with space in filename
9fb1bd5
Commits on Aug 04, 2014
@nobuf nobuf Merge branch 'master' of https://github.com/Empact/roo fdaefec
@nobuf nobuf change some code based on @simonoff's suggestion, add a test #84 1268bee
@simonoff simonoff Merge pull request #118 from nobuf/master
fix #84 check if the filename is String
daeb688
Commits on Aug 12, 2014
@simonoff simonoff Merge pull request #130 from mwmalinowski/master
Move .strip to after .pack in sanitize_value
e0d6f9d
Commits on Sep 18, 2014
@simonoff simonoff Remove supporer notice b7364dc
@thefooj thefooj Test comparison CSV file was missing last row 0d6a234
@thefooj thefooj Hyperlink fix: id attribute is actually r:id - rspec was failing f7e64da
@thefooj thefooj Excel to_csv for Link cell should be url not string 663d475
@thefooj thefooj Adding check for id presence - what rui-castro had done in the first
place

Conflicts:
	lib/roo/excelx.rb
fc54112
@thefooj thefooj refactor out cell handling to separate method
Conflicts:
	lib/roo/excelx.rb
3450e13
@thefooj thefooj refactoring zipfile processing - removing redundant zip open
Conflicts:
	lib/roo/excelx.rb
f7e60e2
@simonoff simonoff Speedup xlsx file parsing. Closes #55, #135 4a1353d
Commits on Sep 25, 2014
@jphastings jphastings Fix for number_to_letter when mathn has been required d4b9ac5
Commits on Nov 15, 2014
@Empact Empact Merge pull request #149 from jphastings/n2l
Fix for `number_to_letter` when mathn has been required
e118a09
@Empact Empact Update the test suite to pass options via a hash, rather than the dep…
…recated positional arguments.
9ed86e6
@Empact Empact Switch from jeweler to the bundlers gem builder. Fixes #147, #148. 21e6945
@Empact Empact Source the gemfile from the gemspec. e0383e5
Commits on Nov 17, 2014
@Empact Empact Drop pry from the dependencies. 8cba79d
@Empact Empact Drop deprecated behavior in prep for roo 2 b7e018d
@Empact Empact Split LibraOffice into its own file. 52d5dd9
@Empact Empact Move open office file to match its class name. bad8b2d
@Empact Empact Prefer tr over simple gsub. 2d32906
@Empact Empact Pull out Roo::Excel, Excel2003XMl, and Google, to be provided in sepa…
…rate libraries, roo-xls and roo-google.
a7edbec
@Empact Empact Avoid using single-character variable names. c39bdd8
@Empact Empact Switch from Spreadsheet::Link to Roo::Link, thus removing spreadsheet…
… dependency.

Also change the behavior of Excelx#celltype to output :link in the proper cases.
ee67321
@Empact Empact Update the license copyright date. ce7c182
@Empact Empact Prefer 'add_dependency' 06a9b95
@Empact Empact Use method-level rescue. 8d49197
@Empact Empact Fail expressively when #row_with fails to find the headers. #129 4e7d7d1
@Empact Empact Back-fill changelog. 4eea745
Commits on Nov 22, 2014
@simonoff simonoff Update version. Migrate to minites. Fix tests. 6412f84
@simonoff simonoff Use symbols as file type key. Upgrade to rspec 3 a5e7c79
@simonoff simonoff Travis CI 6d10403
@Empact Empact Don’t include an extensions list in Roo::Base#file_type_check, and on…
…ly create the warning message if it is to be displayed.
61eacd0
@Empact Empact Extract common file handling logic to local_filename helper. fecca25
@Empact Empact Accept the tmpdir_root option in Excelx. 0e325b6
@Empact Empact Pass the block through to make_tmpdir, thus allowing non-block usage …
…of mktmpdir.
c8308be
@Empact Empact Rename s_attribute to style, and attribute2format to style_format. e0fd768
@Empact Empact A roo_ tmpdir prefix seems more appropriate. 102d5fc
@Empact Empact In Excelx, load styles, shared strings and the workbook lazily.
Leave the tmpdir open so that reading may take place after initialize. The OS will be responsible for cleaning it up.
a973237
@Empact Empact Start extracting a new Excelx::Sheet class to manage the lazy loading…
… and simplify access all around.

Initially it just handles hyperlinks.
4834e20
@Empact Empact Move comments handling into Excelx::Sheet e49a1da
@Empact Empact Lazily initialize @default_sheet, to avoid reading the sheets earlier…
… than necessary. Use the #default_sheet accessor instead.
704e3dc
@Empact Empact Move the implementation of #load_xml to .load_xml as it doesn’t rely …
…on any instance data.
25a018f
@Empact Empact Move Excelx cell management into Excelx::Sheet, and the new Excelx::C…
…ell. Move the existing SharedStrings, Styles, and Workbook management into new extractor classes.
c2bb7b8
@Empact Empact Extract 3 Extractors from Excelx::Sheet, handling Comments, Relations…
…hips, and the SheetsDoc.
0a43341
@Empact Empact Fix that file_type_warning_message wasn't looking up the class properly. 98ed802
Commits on Nov 23, 2014
@simonoff simonoff Remove website from repo 945168f
@simonoff simonoff Travis and CodeClimate badges c023b8f
@simonoff simonoff Remove pry 6a7114a
@simonoff simonoff Coveralls.io badge d7663cd
@simonoff simonoff Fix date test again 21d8630
@simonoff simonoff Send test coverage to coveralls. Allow fail jruby on travis 5f5ca3f
@simonoff simonoff Extract utils and zip_file 3169a0e
Commits on Nov 24, 2014
@Empact Empact Write the OpenOffice content file in one call. fc7d2f2
@Empact Empact Lazily load the OpenOffice doc file. As with Excelx, this means the O…
…S or user will be responsible for cleaning up the temporary files.

Inline OpenOffice#extract_content.
Drop Base#load_xml as it is no longer used.
a74157a
@Empact Empact Inline and simplify OpenOffice.process_zipfile 835368e
@Empact Empact Simplify Excelx#process_zipfile. 2d1b12a
@Empact Empact Drop our Roo::ZipFile abstraction in favor of more recent dependencies. d466950
@Empact Empact Extract Roo::Font to replace equivalent uses in Excelx and OpenOffice. 23e19de
@Empact Empact Ignore the code coverage output. 63996f0
Commits on Nov 28, 2014
@kevgrig kevgrig Support OpenOffice password decryption when encrypted with
AES-256-CBC (no padding) + PBKDF2/HmacSHA1 key and
SHA-256 password hash.
3d5adc3
Commits on Nov 29, 2014
@kevgrig kevgrig Optimize decryption by streaming fixed size blocks directly into
the cipher. Also add more comments and reformat.
a22a413
@simonoff simonoff Remove duplicate code. Cache results for first/last row/column. Doing…
… loop only once.
a0dd800
@kevgrig kevgrig Merge branch 'master' of github.com:roo-rb/roo 47c22db
@kevgrig kevgrig Refactor ODS decryption into multiple methods 966f3ce
@simonoff simonoff Code cleanup from duplicates for base class. Convert dos to unix 85ca578
Commits on Dec 04, 2014
@kevgrig kevgrig Merge commit 85ca578 (note
separate issue #159)
40a7a1d
@kevgrig kevgrig Remove duplicate comment 3e2b862
@kevgrig kevgrig Minor style updates fc6e473
@simonoff simonoff CHange the order of arguments for to_csv to use same logic when sheet…
… is optional last element
1e82a21
Commits on Dec 07, 2014
@kevgrig kevgrig Merge branch 'master' of github.com:roo-rb/roo 20d77db
Commits on Dec 11, 2014
@mgarriott mgarriott Calling Roo::Base#sheet returns the specified sheet 27d3ca3
@simonoff simonoff Merge pull request #160 from mgarriott/master
Calling Roo::Base#sheet returns the specified sheet
5d13b60
Commits on Dec 29, 2014
@rishijain rishijain handled parsing when header has brackets in it 8ed5402
@simonoff simonoff Merge pull request #162 from rishijain/update_special_character
handled parsing when header has brackets in it
126b0bb
@rlburkes rlburkes Merge remote master 54615dd
Commits on Dec 31, 2014
@simonoff simonoff Add ruby 2.2.0 to test scope a3c0724
@rlburkes rlburkes Merge master into fork, update specs. dfd43a9
@rlburkes rlburkes Merge branch 'master' of https://github.com/roo-rb/roo 2c72db0
@rlburkes rlburkes Merge master, update specs. 5ce26bb
@rlburkes rlburkes Fix bad merge on readme. 387fe1a
@rlburkes rlburkes Remove an old test from merge. ab1b32e
Commits on Jan 05, 2015
@simonoff simonoff Merge pull request #69 from rlburkes/master
Support for streamed parsing of very large excelx sheets
12f3f7b
Commits on Jan 06, 2015
@rlburkes rlburkes Allow callers to request information (value, formula, etc.) on cells …
…that might not exist in the document.
66d4882
Commits on Jan 07, 2015
@rlburkes rlburkes Stream the reading of the dimensions for the fast fail case of a larg…
…e import
500c9a9
@rlburkes rlburkes Fix type coercion 39f313a
Commits on Jan 08, 2015
@rlburkes rlburkes Sane coercion of numeric types f695408
Commits on Jan 15, 2015
@ojotoxy ojotoxy Make comment more descriptive 0263bd1
Commits on Feb 05, 2015
@tmjbradley tmjbradley Add support for merged cells, not configurable yet 2bb3c0b
Commits on Feb 06, 2015
@simonoff simonoff Merge pull request #167 from ojotoxy/patch-1
Make comment more descriptive
c3fbd19
@tmjbradley tmjbradley Make expansion of merged cells optional 2f0a2e3
@simonoff simonoff Merge pull request #157 from myplaceonline/master
Support OpenOffice password decryption
3a370f8
@tmjbradley tmjbradley Move merged range expansion to a separate block 80e264b
@tmjbradley tmjbradley Add test for duplicating values in merged ranges 9f33cc7
@tmjbradley tmjbradley Add check for non-expansion (default) of merged cells 8139cc0
@tmjbradley tmjbradley Check surround cells are not affected by merging cells 4042f4a
Commits on Feb 11, 2015
@airblade airblade Use actual regular expressions for header "regex"s. 29332b3
@simonoff simonoff Merge pull request #173 from airblade/master
Use actual regular expressions for header "regex"s.
707ed15
Commits on Feb 28, 2015
@stevendaniels stevendaniels Updated :clean option
The clean option should remove control characters and spaces, instead of
removing all unicode chararacters.
178cb29
Commits on Mar 02, 2015
@malept malept Add optional support for hidden sheets in LibreOffice files 564db90
@malept malept Add optional support for hidden sheets in Excelx files 1097545
Commits on Mar 22, 2015
@stevendaniels stevendaniels Memoize Roo::Utils::split_coordinate.
StackProf results:

Before:
Total allocated 1233956
Total retained 216

allocated memory by gem
-----------------------------------
  77293617  roo/lib
  11120384  rubyzip-1.1.7
   9016024  nokogiri-1.6.6.2
    422730  rubygems
     27053  other
      3528  2.1.3/lib

allocated objects by gem
-----------------------------------
   1062121  roo/lib
    165533  nokogiri-1.6.6.2
      4922  rubygems
      1198  rubyzip-1.1.7
       119  other
        63  2.1.3/lib

retained memory by gem
-----------------------------------
    100805  roo/lib
     17388  other
      5488  rubygems
       209  nokogiri-1.6.6.2
        80  rubyzip-1.1.7
        80  2.1.3/lib

After memoizing Roo::Utils::split_coordinate:
Total allocated 988971
Total retained 50356

allocated memory by gem
-----------------------------------
  61230343  roo/lib
  11120376  rubyzip-1.1.7
   9016024  nokogiri-1.6.6.2
    422730  rubygems
     27053  other
      3528  2.1.3/lib

allocated objects by gem
-----------------------------------
    817136  roo/lib
    165533  nokogiri-1.6.6.2
      4922  rubygems
      1198  rubyzip-1.1.7
       119  other
        63  2.1.3/lib

retained memory by gem
-----------------------------------
   3374741  roo/lib
     17388  other
      5352  rubygems
       209  nokogiri-1.6.6.2
        80  rubyzip-1.1.7
        80  2.1.3/lib
8a8b2c8
@stevendaniels stevendaniels Fixed Roo::Utils.number_to_letter
fixed specs for Roo:Utils.number_to_letter

Removed Roo::Utils::LETTERS
8544c51
Commits on Mar 23, 2015
@stevendaniels stevendaniels Fix :parse method with :clean option
 - Fixes Roo::Excelx.parse method when using :clean option
 - Fixes Roo::CSV.parse method when using :clean option
 - Added tests for parse with :clean option

fixed space
c007842
@Empact Empact Merge pull request #180 from stevendaniels/memory-issues
Fix some memory issues
1fc3c37
@simonoff simonoff Merge pull request #184 from stevendaniels/error-parsing-with-clean
Fix :parse method with :clean option
4cce70a
@simonoff simonoff Update gemspec 461dbbe
@simonoff simonoff User require for base and spreadsheet df1823c
@simonoff simonoff Merge pull request #177 from malept/hidden-sheets
Add optional hidden sheets support
f5d1f93
@simonoff simonoff Merge pull request #171 from tmjbradley/master
Expand merged cells to fill the range
7082620
@simonoff simonoff Skip one test on JRuby. Possible bug in Nokogiri ef4fe46
Commits on Mar 27, 2015
@stevendaniels stevendaniels A less verbose inspect method makes it easier to work with roo in irb or
pry. (#50)

inspect(true) will return the more verbose object inspection.
e8f3ed3
@stevendaniels stevendaniels Rebase using master. 394aeea
@stevendaniels stevendaniels Updated :clean option
 + Excelx clean option updates Cell.value
 + Added tests.
bf96d75
Commits on Mar 28, 2015
@simonoff simonoff Merge pull request #186 from stevendaniels/f/fix-inspect
Use a less verbose inspect method
27ec02c
@simonoff simonoff Merge pull request #176 from stevendaniels/clean-option
Updated :clean option
7ad4de7
Commits on Mar 29, 2015
@stevendaniels stevendaniels Removed debug argument from Roo::Base#inspect method 9399ca4
@stevendaniels stevendaniels Made OpenOffice decrypt methods private dcbefc5
@stevendaniels stevendaniels made Roo::Base#search_or_set_header private ca0f7be
@simonoff simonoff Merge pull request #188 from stevendaniels/f/fix-inspect
Removed debug argument from Roo::Base#inspect method
ab3f97b
@simonoff simonoff Merge pull request #189 from stevendaniels/reduce-public-api-surface
Reduce public api surface
72b1532
Commits on Mar 30, 2015
@stevendaniels stevendaniels Updated Readme 3e5383f
@stevendaniels stevendaniels Return value from formula? method should be consistent. fe29f9f
@stevendaniels stevendaniels Cherry picked patches from #165 9b59c0c
@stevendaniels stevendaniels Skip failing JRuby test. f3ef144
Commits on Mar 31, 2015
@simonoff simonoff Merge pull request #190 from stevendaniels/updated-readme
Updated Readme
c6195af
@simonoff simonoff Merge pull request #191 from stevendaniels/make-formula-methods-consi…
…stent

Return value from formula? method should be consistent.
7f6b8e3
@simonoff simonoff Merge pull request #192 from stevendaniels/cherry-picked-pull-165
Cherry picked pull #165
29d9cfb
@stevendaniels stevendaniels Update the gemspec and reduce the published gems size 25942a6
Commits on Apr 02, 2015
@diegotoral diegotoral Update README.md
Highlight code snippets.
1677622
@stevendaniels stevendaniels Merge pull request #195 from diegotoral/patch-1
Make the README a little colorful
97e8fc5
Commits on Apr 07, 2015
@stevendaniels stevendaniels Increased version range for gem dependencies 760ddf8
Commits on Apr 08, 2015
@stevendaniels stevendaniels Extract sheets in the correct order 474c40c
@stevendaniels stevendaniels Fix comments for google exported xlsx 44033f6
Commits on Apr 09, 2015
@simonoff simonoff Merge pull request #194 from stevendaniels/update-gemspec
Update the gemspec and reduce the published gems size
dc490fa
@simonoff simonoff Merge pull request #197 from stevendaniels/comments
Fix comments for google exported xlsx
5084e99
@stevendaniels stevendaniels Refactored Roo::Excelx#process_zipfile
Extracted another method from process_zipfile. I could do more
refactoring to reduce the line count, but readability might suffer.
e.g.

      when /sharedstrings.xml$/
        ...
      when /styles\.xml$/
        ...

becomes

    when /(sharedstrings|styles)\.xml$/
      "#{tmpdir}/roo_#{Regexp.last_match[1]}.xml"
4e93b7c
@simonoff simonoff Merge pull request #196 from stevendaniels/return-the-correct-sheet
Extract sheets in the correct order
ab59137
@simonoff simonoff Ser version to beta1 66fe454
@simonoff simonoff Update roo version in README [skip ci] b927aa9
Commits on Apr 10, 2015
@simonoff simonoff Fix roo version in README [skip ci] 840ebe1
Commits on Apr 11, 2015
@stevendaniels stevendaniels Make Base#clean_sheet_if_need private
This method is used internally and doesn't need to be public.
8527bfb
Commits on Apr 12, 2015
@simonoff simonoff Merge pull request #198 from stevendaniels/make-clean-sheet-if-need-p…
…rivate

Make Base#clean_sheet_if_need private
6221b96
@stevendaniels stevendaniels Updated CHANGELOG.
Switched to the `CHANGELOG` format to the keepachangelog.com format. #193
c241527
Commits on Apr 13, 2015
@simonoff simonoff Merge pull request #199 from stevendaniels/updated-changelog
Updated CHANGELOG.
6ec9154
@stevendaniels stevendaniels updated Changelog 72b6875
@jmuheim jmuheim Fix wrong instruction 52d3709
@stevendaniels stevendaniels Merge pull request #200 from jmuheim/master
Fix wrong instruction in README: Excelx.new (instead of only Excelx)
beae020
Commits on Apr 22, 2015
@cbliard cbliard Fix link to Changelog b2d1ad2
@stevendaniels stevendaniels Merge pull request #204 from cbliard/patch-1
Fix link to Changelog in Readme
f93c3bd
Commits on Apr 24, 2015
@simonoff simonoff Release 2.0.0 e7216e2
Commits on Apr 27, 2015
@subelsky subelsky Update CHANGELOG to reflect v2.0.0 release 3749f74
@subelsky subelsky Add v2.0 release date to CHANGELOG ceacedb
Commits on Apr 29, 2015
@lastobelus lastobelus don't kak on Pathname in excelx, openoffice a527799
Commits on May 04, 2015
@samhowley samhowley cell_to_csv for double quote escaping changed all tr to gsub
tr is not escaping double quote characters correctly, replaced with call to gsub.
ea40775
@stevendaniels stevendaniels Merge pull request #206 from subelsky/patch-1
Update CHANGELOG to reflect v2.0.0 release
1a8dd8c
@stevendaniels stevendaniels Merge pull request #207 from lastobelus/handle_pathname
don't kak on Pathname in excelx, openoffice
3da85b8
@stevendaniels stevendaniels Updated changelog 38d708d
@stevendaniels stevendaniels Removed the scripts folder.
This doesn't seem to do anything anymore. The code doesn't seem to be
called anywhere.
8db6d2c
@afn afn Fixes #75 allow Roo::Excelx to open streams f411c07
Commits on May 06, 2015
@ignat-zakrevsky ignat-zakrevsky Offset option for excelx #each_row 8bb5517
Commits on May 07, 2015
@simonoff simonoff Merge pull request #214 from ignat-zakrevsky/offset-feature-for-excelx
Offset option for excelx #each_row
d9daa4e
@simonoff simonoff Merge pull request #213 from stevendaniels/remove-deprecated-scripts
Removed the scripts folder.
1fa436a
@simonoff simonoff Updates changelog [skip ci] 4ca8621
@simonoff simonoff Merge pull request #209 from amitree/open_streams
Fixes #75 allow Roo::Excelx to open streams
63b88c2
Commits on May 08, 2015
@afn afn Adding Roo::Base#close to delete any temp directories
Fixes #210
0e2cb40
Commits on May 12, 2015
@afn afn Ensuring that close is called if #initialize fails 7fddb7c
Commits on May 14, 2015
@simonoff simonoff Fix style d3079f7
@simonoff simonoff Merge branch 'amitree-cleanup_temp' b2da654
Commits on May 15, 2015
@stevendaniels stevendaniels Moved Excelx::Cell, Excelx::Sheet
+ Autoload Excelx::Cell and Excelx::Sheet
+ Added excelx/cell.rb
+ Added exelx/sheet.rb
3930052
@stevendaniels stevendaniels Refactored Excelx::Cell datetime functions
+ Used Regexp capture match groups instead of multiple `split` methods
+ added private `create_date` method
+ renamed private methods
3f4b0a7
Commits on May 16, 2015
@stevendaniels stevendaniels Linted Excelx classes. e9a8894
@stevendaniels stevendaniels Updated CHANGELOG 67381a6
Commits on May 17, 2015
@simonoff simonoff Cleanup starting b944dff
Commits on May 28, 2015
@stevendaniels stevendaniels Cleanup Excelx classes
+ require Excelx's submodules instead of autoloading.
+  Use guard class in Excelx::Comments#extract_comments and
Excelx::Relationships.extract_relationships
+ Updated conditionals in Excelx::Cell.
023bc4d
@stevendaniels stevendaniels Merge branch 'master' of https://github.com/samhowley/roo into samhow…
…ley-master
d0f3e08
@stevendaniels stevendaniels Added tests for cell_to_csv double quote escape 793366d
@stevendaniels stevendaniels Linting 1b71d1c
@stevendaniels stevendaniels Merge branch '212-patch' fcc9a01
@stevendaniels stevendaniels Merge pull request #215 from stevendaniels/cleanup_excelx
Cleanup Excelx
84982e0
Commits on May 31, 2015
@pabloh pabloh Return an enumerator when calling '#each' without a block 6bdb9a1
@stevendaniels stevendaniels Merge pull request #219 from pabloh/return_enumerator_from_each
Return an enumerator when calling '#each' without a block
971a9d7
Commits on Jun 01, 2015
@stevendaniels stevendaniels Use Shared class to pass shared data to Excelx Sheets. 9110c92
@stevendaniels stevendaniels Excelx::Sheet and Excelx::SheetDoc use shared data
This changes the initializers for Roo::Excelx::Sheet and
Roo::Excelx::SheetDoc, so a minor version bump will be required.
4b41a2e
@stevendaniels stevendaniels Update to 2.0.1 ae94acc
Commits on Jun 02, 2015
@stevendaniels stevendaniels More linting and minor refactoring 9c05897
@afn afn Zip::InputStream doesn't handle all zip files
Excel files exported from Google, for example, aren't supported.
Using Zip::CentralDirectory instead seems to do the trick.
2382b3c
Commits on Jun 03, 2015
@simonoff simonoff Merge pull request #222 from amitree/correctly_handle_xlsx_streams
Allow Roo::Excelx to open streams, correctly this time
16dcb43
Commits on Jun 09, 2015
David Lanner return an enumerator when calling each_row_streaming without a block c92bc0d
David Lanner add test for each_row_streaming enumerator case 0567d35
Commits on Jun 10, 2015
@simonoff simonoff Merge pull request #224 from dlanner/return_enumerator_from_each_row_…
…streaming

Return an enumerator when calling each_row_streaming without a block
8fabd03
Commits on Jun 21, 2015
@pabloh pabloh Update regexp to check for an url at Spreasheet.open 984d550
Commits on Jun 22, 2015
@simonoff simonoff Merge pull request #229 from pabloh/update_regexp_open_spreadsheet
Update regexp to check for an url at Spreasheet.open
c796bfc
Commits on Jun 26, 2015
@stevendaniels stevendaniels Fix invalid new lines.
Fixes #223.
9aca2ca
Commits on Jul 05, 2015
@pabloh pabloh Add suport for Excel 2007 xlsm files 93a5de5
Commits on Jul 08, 2015
@simonoff simonoff Merge pull request #232 from pabloh/support_opening_xlsm_files
Add suport for Excel 2007 xlsm files
c4fde4c
@pabloh pabloh Replace CRLF line terminator for unix line terminators abd6b50
@stevendaniels stevendaniels Merge pull request #234 from pabloh/delete_windows_CRLF_line_terminators
Replace CRLF line terminator with unix line terminators
4adca5a
@stevendaniels stevendaniels Replace hard tabs with soft tabs 1b1eb32
@stevendaniels stevendaniels Merge pull request #235 from stevendaniels/replace-hard-tabs
Replace hard tabs with soft tabs
a27e2b8
@stevendaniels stevendaniels Linting Roo::Base 2246a59
@stevendaniels stevendaniels Linting and minor refactoring Roo::Base 99bd965
@stevendaniels stevendaniels Updated changelog 81e8b4e
@stevendaniels stevendaniels Updated readme 3b84a00
@stevendaniels stevendaniels Merge pull request #216 from roo-rb/openoffice-refactoring
Openoffice refactoring
e7e2f3c
Commits on Jul 15, 2015
@pabloh pabloh Convert generic spreadsheet tests to rspec 9cb6b68
Commits on Jul 17, 2015
@stevendaniels stevendaniels Add Proper Type support to Excelx. e2525c7
Commits on Jul 18, 2015
@pabloh pabloh Release Roo 2.1.0 3f367d9
Commits on Jul 20, 2015
@stevendaniels stevendaniels Merge pull request #241 from pabloh/release_2_1
Release Roo 2.1.0
7294dd4
Commits on Jul 23, 2015
@stevendaniels stevendaniels Updated travis.yml ba51cd5
@stevendaniels stevendaniels Rebase from master f0b6428
@stevendaniels stevendaniels Added specs for fixing _x000D_ issue dc33d30
@stevendaniels stevendaniels Added specs for fixing _x000D_ issue 2a1a350
@stevendaniels stevendaniels Merge pull request #231 from stevendaniels/fix-invalid-_x000D_-character
Fix invalid new lines.
a174a38
@stevendaniels stevendaniels Merge pull request #236 from stevendaniels/roo-base-linting
Linting and minor refactoring Roo::Base
4a43326
@stevendaniels stevendaniels Updated Changelog caacf36
Commits on Jul 26, 2015
@stevendaniels stevendaniels Updated readme 0e79707
Commits on Aug 01, 2015
@simonoff simonoff Merge pull request #239 from pabloh/convert_generict_tests_to_rspec
Convert generic spreadsheet tests to rspec
d93bcf2
@stevendaniels stevendaniels Require URI. 47a7e60
@stevendaniels stevendaniels Merge pull request #245 from stevendaniels/require-uri
Require URI.
2d460b6
@stevendaniels stevendaniels Roo Version 2.1.1 fa7feb7
Commits on Aug 13, 2015
@reshleman reshleman Add Passing Specs for `Roo::Base#row_with`
* Test 1 case with matching row and 1 without a matching row
76b606e
@reshleman reshleman Missing Header Raises `Roo::HeaderRowNotFoundError`
Currently, Roo raises a generic `RuntimeError` with the message
"Couldn't find header row" when a matching header row is not found.

This behavior makes it difficult to rescue from the most specific error
desired, because `RuntimeError` is the default error class for `raise`.

Additionally, because Roo does not have its own library-level error
class from which all errors inherit, it is difficult to differentiate
Roo library errors from errors caused by the developer / user.

From the [Ruby documentation][1]:

> It is recommended that a library should have one subclass of
> `StandardError` or `RuntimeError` and have specific exception types
> inherit from it. This allows the user to rescue a generic exception
> type to catch all exceptions the library may raise even if future
> versions of the library add new exception subclasses.

This commit adds a generic `Roo::Error` class which inherits from
`StandardError` and a specific `Roo::HeaderRowNotFound` class that is
raised when a matching header row could not be found.

In the future, additional subclasses of `Roo::Error` can be added in
order to allow users to more easily rescue the correct errors.

Note: This is *not* a backwards-compatible change. Users who currently
rescue `RuntimeError` for a missing header row will now see an error
raised.

[1]: http://ruby-doc.org/core-2.2.2/Exception.html
df53d9a
@simonoff simonoff Merge pull request #247 from reshleman/re-raise-header-error
Missing Header Raises `Roo::HeaderRowNotFoundError`
4d747d9
Commits on Aug 20, 2015
@stevendaniels stevendaniels Merge pull request #220 from stevendaniels/use_shared_class
Use Excelx::Shared class to pass shared data to Excelx Sheets.
9b4e67c
@stevendaniels stevendaniels Merge branch master into proper-cell-types-for-excelx b7890dd
@stevendaniels stevendaniels Merge pull request #240 from stevendaniels/proper-cell-types-for-excelx
Add Proper Type support to Excelx.
23d6244
Commits on Aug 21, 2015
@stevendaniels stevendaniels Updated gemspec 94a02da
@stevendaniels stevendaniels Updated changelog f8237a9
@fabien-michel fabien-michel Update README.md
Add each_row_streaming options (offset, max_rows and pad_cells)
9f82b70
@fabien-michel fabien-michel Update README.md 0e35ed5
Commits on Aug 23, 2015
@stevendaniels stevendaniels Merge pull request #250 from fabien-michel/patch-1
Update README.md
dc3786b