Use chi.Router interface for AttachRoutes method

[JVecsei1]

Is your feature request related to a problem? Please describe.

For some methods chi returns the interface type chi.Router, e.g. when using the Route method on *chi.Mux to create a subrouter.

The AttachRoutes method currently uses the concrete implementation instead of the chi.Router interface, although it only relies on methods exposed by chi.Router.

Describe the solution you'd like

Changing the AttachRoutes method to accept the chi.Router interface type, instead of *chi.Mux would make it easier to use in some scenarios.

func AttachRoutes(router chi.Router, serviceBroker ServiceBroker, logger lager.Logger) {
	attachRoutes(router, serviceBroker, logger)
}

func attachRoutes(router chi.Router, serviceBroker ServiceBroker, logger lager.Logger) {
    // ...
}

Describe alternatives you've considered

Using a subrouter can still be achieved by creating a new router and mounting it manually, but methods such as Route or Group could only be used with type assertions.

subRouter := chi.NewRouter()
router.Mount("/my-route", subRouter)

Additional context

No response

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185332433

The labels on this github issue will be updated when the story is started.

[blgm]

Hi @JVecsei1. This makes complete sense. I've create a PR to resolve that. Before I merge it, I just thought I'd give you a chance to take a look and try it out, to make sure it's what you were expecting.

[JVecsei1]

Hi @JVecsei1. This makes complete sense. I've create a PR to resolve that. Before I merge it, I just thought I'd give you a chance to take a look and try it out, to make sure it's what you were expecting.

Hi @blgm ,

thanks a lot for the quick response & implementing the change. Looks great 👍