Skip to content

Allow dependencies file directory to be configured #8

Merged
merged 3 commits into from Jul 16, 2012

2 participants

@travis
travis commented Jun 11, 2012

Allow projects to configure the location where dependencies.txt
and dependencies.yml are written using the dependencies_file_dir
config variable.

@travis travis Allow dependencies file directory to be configured
Allow projects to configure the location where dependencies.txt
and dependencies.yml are written using the dependencies_file_dir
config variable.
8fbb501
@pivotalcommon

Thanks for this, what problem exactly are you trying to solve with this pull request? Has it been harmful to have those files in the default location, or are you trying to pipe them somewhere else for a third party service to act on?

@travis
travis commented Jun 21, 2012

One of our developers was just annoyed that we couldn't avoid cluttering up the top level directory of our project.

@pivotalcommon

If you can get it apply cleanly to master we're all for your pull request

@travis travis Merge branch 'master' of github.com:pivotal/LicenseFinder
Conflicts:
	lib/license_finder/finder.rb
	spec/finder_spec.rb
8c44944
@travis
travis commented Jun 21, 2012

cool - should be good to go now. thanks!

@pivotalcommon

Hi @travis. Can you please rebase again so we can get this merged? Sorry for the delay!

@travis travis Merge remote-tracking branch 'upstream/master'
Conflicts:
	lib/license_finder/finder.rb
	spec/finder_spec.rb
a7d1860
@travis
travis commented Jul 2, 2012

ok - merged again

@pivotalcommon pivotalcommon merged commit cd074bf into pivotal:master Jul 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.