Permalink
Browse files

Make exception symbolication an opt-in feature

  • Loading branch information...
1 parent a3cfc35 commit 39862bbbed77438e9dc3b20f44b06b9735a9dc3e Dmitriy Kalinin committed Mar 29, 2013
Showing with 6 additions and 6 deletions.
  1. +3 −3 README.markdown
  2. +3 −3 Source/CDRDefaultReporter.m
View
@@ -419,9 +419,9 @@ path can be overridden with the `CEDAR_JUNIT_XML_FILE` env variable.
### Exception Symbolication
-By default Cedar symbolicates exceptions that caused test failures; however,
-this feature might be turned off with `CEDAR_SKIP_EXCEPTION_SYMBOLICATION`
-since symbolicating many exceptions can become a lengthy operation.
+By default Cedar does not symbolicate exceptions that caused test failures,
+since symbolicating many exceptions can become a lengthy operation;
+however, this feature can be turned on with `CEDAR_SYMBOLICATE_EXCEPTIONS`.
## Code Snippets
@@ -109,8 +109,8 @@ - (NSString *)errorMessageForExample:(CDRExample *)example {
- (NSString *)callStackSymbolsForFailure:(CDRSpecFailure *)failure {
// Currently to symbolicate an exception
- // we shell out to atos; thus this opt-out setting.
- if (getenv("CEDAR_SKIP_EXCEPTION_SYMBOLICATION")) return nil;
+ // we shell out to atos; thus this opt-in setting.
+ if (!getenv("CEDAR_SYMBOLICATE_EXCEPTIONS")) return nil;
NSError *error = nil;
NSString *callStackSymbols =
@@ -120,7 +120,7 @@ - (NSString *)callStackSymbolsForFailure:(CDRSpecFailure *)failure {
if (error.code == kCDRSymbolicatorErrorNotSuccessful) {
NSString *details = [error.userInfo objectForKey:kCDRSymbolicatorErrorMessageKey];
printf("Exception symbolication was not successful.\n"
- "You can turn it off with CEDAR_SKIP_EXCEPTION_SYMBOLICATION.\n"
+ "To turn it off remove CEDAR_SYMBOLICATE_EXCEPTIONS.\n"
"Details:\n%s\n", details.UTF8String);
}
}

0 comments on commit 39862bb

Please sign in to comment.