Add examples for tbs default repo values #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerphelan
commented
Nov 8, 2021
tylerphelan
commented
- Also add clarity around default repo credentials
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
- These values are often misconfigured - Add clarity around default repo credentials
tylerphelan
force-pushed
the
tbs-profile-values
branch
from
5c7460b
to
d0d33f5
Compare
matthewmcnew
reviewed
Nov 8, 2021
| - `<REPO-NAME>` is the location in the registry where workload images will be written to. | ||
| * Examples: | ||
| * Harbor `repository: "my-project/supply-chain"` | ||
| * Dockerhub `repository: "my-dockerhub-user/supply-chain"` |
There was a problem hiding this comment.
I think this will break on Dockerhub because it will write images to my-dockerhub-user/supply-chain/my-workload-image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.