Skip to content
This repository

Fix swapped template values in build_standalone_runner.rb. #242

Merged
merged 1 commit into from almost 2 years ago

2 participants

Christopher Mitchell Davis W. Frank
Christopher Mitchell

This fixes a bug in build_standalone_runner.rb that causes the standalone SpecRunner.html to appear to have wrongly-ordered comments. The SpecRunner.html comments gave my coworker and me a short pause when we first started using Jasmine (jasmine-standalone-1.2.0.zip).

Christopher Mitchell ChrisTM Fix swapped template values in build_standalone_runner.rb.
`example_source_tags` and `example_spec_tags` each returned what the other
should have returned. I noticed this bug because it made the comments in
SpecRunner.html about where to include spec and source files incongruous with
the example tags that followed.
4c28bef
Davis W. Frank infews merged commit 5ca2888 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jun 17, 2012
Christopher Mitchell ChrisTM Fix swapped template values in build_standalone_runner.rb.
`example_source_tags` and `example_spec_tags` each returned what the other
should have returned. I noticed this bug because it made the comments in
SpecRunner.html about where to include spec and source files incongruous with
the example tags that followed.
4c28bef
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 3 additions and 3 deletions. Show diff stats Hide diff stats

  1. +3 3 tasks/jasmine_dev/build_standalone_runner.rb
6 tasks/jasmine_dev/build_standalone_runner.rb
@@ -49,11 +49,11 @@ def example_jasmine_tags
49 49 end
50 50
51 51 def example_source_tags
52   - script_tags_for ['spec/SpecHelper.js', 'spec/PlayerSpec.js']
  52 + script_tags_for ['src/Player.js', 'src/Song.js']
53 53 end
54 54
55 55 def example_spec_tags
56   - script_tags_for ['src/Player.js', 'src/Song.js']
  56 + script_tags_for ['spec/SpecHelper.js', 'spec/PlayerSpec.js']
57 57 end
58 58 end
59   -end
  59 +end

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.