Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Container & Helm chart #197
Build docker container and adds a helm chart for deployment to kubernetes
I think this is ready for beta testing so am keen to merge it to start getting feedback. Check the README.md in the deployment/helm folder for more detail on how to use the chart.
I've taken a best stab at hooking this into the release process but suspect there will be some finessing once we merge to get it publishing properly. There are a couple of places where I need to change the repository from crswty/postfacto to pivotal/postfacto, i'll do that post review butt pre merge.
* Write config.js out when container starts * Provide config.js values through ENV * Unset oauth if value is empty as well as not provided
Because we run db migrations before the app starts, we need to guarentee that postgres is running before we try to start the postfacto container
textbook left a comment
Generally looks OK, although I don't know enough about most of the Helm stuff to have an opinion either way! I've left a few comments, up to you whether you think they need addressing right now.