Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container & Helm chart #197

Merged
merged 18 commits into from Nov 3, 2019
Merged

Container & Helm chart #197

merged 18 commits into from Nov 3, 2019

Conversation

@crswty
Copy link
Contributor

crswty commented Oct 26, 2019

Build docker container and adds a helm chart for deployment to kubernetes

I think this is ready for beta testing so am keen to merge it to start getting feedback. Check the README.md in the deployment/helm folder for more detail on how to use the chart.

I've taken a best stab at hooking this into the release process but suspect there will be some finessing once we merge to get it publishing properly. There are a couple of places where I need to change the repository from crswty/postfacto to pivotal/postfacto, i'll do that post review butt pre merge.

This addresses the following issues:
#191
#115

  • I have reviewed the contributing guide

  • I have made this pull request to the master branch

  • I have run all the tests using ./test.sh.

  • I have added the copyright headers to each new file added

  • I have given myself credit in the humans.txt file (assuming I want to)

crswty added 9 commits Oct 23, 2019
* Add option to disable SSL redirection
* Not yet working with google auth
* Write config.js out when container starts
* Provide config.js values through ENV
* Unset oauth if value is empty as well as not provided
Because we run db migrations before the app starts, we need to guarentee
that postgres is running before we try to start the postfacto container
@crswty crswty mentioned this pull request Oct 26, 2019
1 of 2 tasks complete
@crswty crswty force-pushed the crswty:feat-docker-release branch 4 times, most recently from 54ec3a2 to 764a6f4 Oct 26, 2019
@crswty crswty force-pushed the crswty:feat-docker-release branch 4 times, most recently from f1561e2 to c6aa242 Oct 26, 2019
@crswty crswty force-pushed the crswty:feat-docker-release branch from c6aa242 to fb93140 Oct 26, 2019
@crswty crswty requested a review from textbook Oct 27, 2019
@crswty crswty marked this pull request as ready for review Oct 27, 2019
@crswty

This comment has been minimized.

Copy link
Contributor Author

crswty commented Oct 27, 2019

Hey @textbook could you take a look at at least the docker part of this?

Happy to take feedback on the helm stuff as well if you have some but was expecting to probably not get a review of that part.

Copy link
Contributor

textbook left a comment

Generally looks OK, although I don't know enough about most of the Helm stuff to have an opinion either way! I've left a few comments, up to you whether you think they need addressing right now.

.travis.yml Outdated Show resolved Hide resolved
deployment/helm/README.md Outdated Show resolved Hide resolved
docker.sh Outdated Show resolved Hide resolved
docker/ci-push Outdated Show resolved Hide resolved
docker/release/Dockerfile Outdated Show resolved Hide resolved
docker/release/Dockerfile Outdated Show resolved Hide resolved
deployment/helm/values.yaml Outdated Show resolved Hide resolved
@crswty crswty merged commit b156a1b into pivotal:master Nov 3, 2019
2 checks passed
2 checks passed
ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.