Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to files to delete in package script (fixes #207) #208

Merged
merged 1 commit into from Dec 12, 2019

Conversation

@textbook
Copy link
Contributor

textbook commented Nov 30, 2019

Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

    Actually removes the .bundle directory and .gitignore file from the packaged assets.

  • An explanation of the use cases your change solves

    Heroku deployment uses git to push the assets, so the ignore file was causing the built client assets not to be included. This meant that, although the admin panel worked and no data was impacted, you couldn't actually use the app.

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have made this pull request to the master branch

  • I have run all the tests using ./test.sh.

  • I have added the copyright headers to each new file added

  • I have given myself credit in the humans.txt file (assuming I want to)

@miccheng

This comment has been minimized.

Copy link

miccheng commented Dec 12, 2019

@textbook Is this good to merge? Seems like this bug exists in 4.0.0 as well. And it's blocking me from deploying the app.

@textbook

This comment has been minimized.

Copy link
Contributor Author

textbook commented Dec 12, 2019

@miccheng thanks for the reminder, in the absence of any objections I'll merge this now and cut a bugfix release. In the meantime you can also delete the .gitignore manually from the unzipped release package if you're running the script manually.

@textbook textbook merged commit 131ed3b into pivotal:master Dec 12, 2019
6 checks passed
6 checks passed
ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - api/Gemfile.lock (textbook) No manifest changes detected
security/snyk - e2e/Gemfile.lock (textbook) No manifest changes detected
security/snyk - mock-google-server/package.json (textbook) No manifest changes detected
security/snyk - web/package.json (textbook) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.