This repository has been archived by the owner on Mar 1, 2023. It is now read-only.
Flaky Felicity E2E test click workaround (fixes #162) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Garofalo mgarofalo@pivotal.io
Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Invoke Javascript click for marking retro items as 'done' instead of relying on Capybara/Selenium click which seems to be inconsistent. (https://medium.com/@yuliaoletskaya/capybara-inconsistent-click-behavior-and-flickering-tests-f50b5fae8ab2)
An explanation of the use cases your change solves
Flaky Felicity Journey E2E test. (Flaky end-to-end tests/timing issues #162)
Links to any other associated PRs
I have reviewed the contributing guide
I have made this pull request to the
masterbranchI have run all the tests using
./test.sh.I have added the copyright headers to each new file added
I have given myself credit in the humans.txt file (assuming I want to)