AES Encryption instead of 3DES #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md to correct 'thier' to 'their'
Added support for FamilyShield DNS from OpenDNS/CISCO
Previous commits removed the duplicate cn option all together, this adds a comment to inform users of their options/choice.
Added FamilyShield DNS server as option
|
This sounds like a no-brainer; I like this! |
Added fix to prevent DNS leak on Windows 10
DNS leak fix in server_config.txt
|
First off, thanks for contributing! I think we were using 3DES for compatibility with iPhones or something. A quick seach through the open issues found #171. |
|
@redfast00 AES128 works fine with iPhones (AES256 works too). |
|
@orazioedoardo thanks. I can now merge this, but this PR contains a lot of unrelated commits and I don't think it's been tested yet. Any input @cfcolaco ? |
|
@redfast00 think this PR is actually cool ... will merge into test all commits to master that are ahead of Test branch! so should be fairly safe to merge this PR into test ( as it is ) =)
|
Changed permission bits on text files.
Great for readable naming conventions.
Changing name validation regex to allow dashes
|
so are we merging this, i'm all for it |
Merge commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why in the script the encryption method 3DES is used. This algorithm is long outdated and deprecated. By simply choosing the AES with 128 bits key length the saved key would be safer for being brute-forced. Therefore it would be a security bonus without changing much.