Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

empty translations string should default to english (Catalan translation is partially broken) #1003

Closed
mattab opened this Issue · 12 comments

2 participants

@mattab
Owner

From email:

If you go to piwik online demo and choose catalan language, piwik does not work correctly. Try to go , for exemple, to "referers" tab... You cannot.

I think the translation is bad-formed, I think some errors like characters like which are escaped ç , and that's because it doesn't work.

@robocoder
Collaborator

latest rev in svn worksforme.

matt: can you svn up piwik.org/demo-trunk ?

@mattab
Owner

I updated demo-trunk and is broken too (look at Referers>Overview which doesn't load)

Note: we should update unit test to detect this broken use case.

@robocoder
Collaborator

In [1493], Add missing widget category name.

@robocoder
Collaborator

I think the proper fix is to eliminate the translation of the widget category name in Piwik_Add():

        $widgetCategory = Piwik_Translate($widgetCategory);

because many of the widget category names are neither translated nor translateable:

'Actions_Actions'
'Example Widgets'
'General_Visitors'
'GeoIP'
'Live!'
'Referers'
'UserSettings_VisitorSettings'
'Visits Summary'
'VisitTime_SubmenuTimes'
@robocoder
Collaborator

scratch that... I forgot category names are used in Widgetize.

@robocoder
Collaborator

p.s. to explain the bug/fix: because the translated string was "", json_encode (on piwik.org) discarded the UserSettings widgets when serializing. On my server, json_encode used "" for the widget category name.

@robocoder
Collaborator

In [1495], refs #1003; use translation strings for consistency

@mattab
Owner

The translation manager should have used the english translation if the original translation string was "empty" - does your comment mean that this is not working as expected?

@robocoder
Collaborator

The translation manager uses the English string if the translation string is not defined (see array_merge). In the Catalan translation, it was defined as an empty string.

@mattab
Owner

reopening it's a quick fix

@robocoder
Collaborator

In [1501], fixes #1003 - filter empty translations

@robocoder
Collaborator

In [1502], refix #1003

In [1503], refs #1003 - filter empty translations when counting percentage translated

@mattab mattab added this to the Piwik 0.4.4 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.