Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a custom search engine is added and it has the same domain as the website tracked, referrer is not detected as expected #10121

Closed
mgonera opened this issue May 4, 2016 · 1 comment
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mgonera
Copy link

mgonera commented May 4, 2016

If we have website tracked with domain of example.com, and using ReferrersManager we define an external search engine to be tracked as referrer, with address containing website domain (search.example.com), then it won't be detected as external search engine but internal website referrer.

Can this be improved so we can fulfill such a usecase?

@sgiehl
Copy link
Member

sgiehl commented May 4, 2016

Problem is the referrer type detection in https://github.com/piwik/piwik/blob/master/plugins/Referrers/Columns/Base.php#L98-L119
Switching the order of direct entry and search engine detection would solve that for your case, but might have an impact on other cases (e.g. a search engine itself wouldn't be able to track with piwik, as each request would be detected as external request).
Guess we should invest some deeper thoughts on that to avoid problems with other edge cases.

@sgiehl sgiehl self-assigned this May 13, 2016
@sgiehl sgiehl added this to the 2.16.2 milestone May 13, 2016
@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label May 13, 2016
@mattab mattab changed the title External search engine with same domain as website causes Referrer detection to fail When a custom search engine is added, and it is the same domain as the website being tracked, the search engine referrer should be detected correctly website Aug 3, 2016
@mattab mattab changed the title When a custom search engine is added, and it is the same domain as the website being tracked, the search engine referrer should be detected correctly website When a custom search engine is added and it has the same domain as the website tracked, referrer is not detected as expected Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants