Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Replace thickbox 3.1 #1029

Closed
robocoder opened this Issue · 3 comments

2 participants

@robocoder
Collaborator

Issues:

  • FF3/Safari: feedback form; scrollbar(s) appear; worse in FF3 because submit button is obscured
  • ThickBox 3.1 is no longer maintained

Proposal:

  • replace thickbox with jquery-ui dialog.

Reference:

@pebosi

Attachment: Please review and try my patch to replace thickbox with jquery ui dialoh
piwik-dialog.patch

@pebosi

patch added.

@robocoder
Collaborator

In [1614], fixes #1029 - replace obsolete/unsupported thickbox with jqueryui dialog

Thanks pebosi!

Minor changes to patch to only add the iframe once and handle case where the Feedback plugin is disabled.

@robocoder robocoder added this to the Piwik 0.5 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.