Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

IE8 (native mode) regression: clicking on the table rows doesn't show the sub tables #1062

Closed
mattab opened this Issue · 16 comments

3 participants

@mattab
Owner

in IE8, clicking on a table's row, for example on a search engine row, doesn't open the list of keywords. No javascript errors are thrown.
Other features such as: sorting, filtering, displaying tag clouds, work as expected.

It shouldn't be a big deal but there might be some small imcompatibility between IE and FF in the datatable code? it is a regression as it was working in some earlier versions of Piwik in IE.

@anonymous-piwik-user

Same problem with IE8 (I think this is an general Internet Explorer problem). With 0.4.5 it work without any problems.

@robocoder
Collaborator

Attachment:
screenshot.jpg

@robocoder
Collaborator

Tested against piwik.org/demo. Unable to reproduce. Subtables are expanding/collapsing as expected. See attached screenshot with IE7 on Vista.

@mattab
Owner

It's actually with IE8, sorry about misinformation ; can you reproduce in IE8?

@robocoder
Collaborator

In [1671], refs #1062 - use IE7 compatibility mode for IE8; temporary workaround for jQuery bug in Sizzle

@mattab
Owner

Is this a known sizzle bug for sure? did you by any chance pin point the actual jquery selection that wasn't working in IE8 but should have?

@anonymous-piwik-user

I tested it with 2 Piwik installations under vista/IE8 and subtables are expanding as
expected

@robocoder
Collaborator

jQuery 1.4.1 was released today. I'll hopefully find time to test this without the IE7 compatibility mode hack.

@robocoder
Collaborator

(In [1802]) refs #1062 - fix IE8 compat buster in jQuery 1.4.1 where attr() may return null instead of undefined

@robocoder
Collaborator

New regressions with jQuery 1.4.1 and IE8:

  • page load errors; note the crazy line numbers
Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Timestamp: Tue, 26 Jan 2010 20:49:50 UTC

Message: Expected identifier, string or number
Line: 118672802
Char: 2
Code: 0
URI: http://my.url/piwik/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday

Message: Object doesn't support this property or method
Line: 118672694
Char: 4
Code: 0
URI: http://my.url/piwik/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday
  • can't add widget; can't delete widgets
  • drag and drop widget causes "Problem has occurred"
  • datatable footer icons disappear when some action taken (e.g., changing chart type, Next, exclude low population, etc.)
@robocoder
Collaborator

(In [1804]) refs #1062 - fix page load errors when Live widget added to dashboard

@robocoder
Collaborator

Firefox regressions with jQuery 1.4.1:

  • can't add/delete widgets
  • anchors not constructed from urlLinks in subtables (e.g., search engine, keywords)
  • datatable footer icons disappear
@mattab
Owner

Anthon, can you please clarify the current status of trunk for IE8 / IE7 / FF compatibility? Features such as add/delete widgets, anchors in subtables, datatable footers are all must-have in these 3 browsers. Is this working currently in trunk?

@robocoder
Collaborator

Sure, to clarify: the regressions in comment:11 and comment:13 are not in trunk. The UI functionality in trunk is as it was in 0.5.4.

I have not checked in the new versions of jquery and jquery-ui (or the related fixes that I'm working on) yet. I was expecting jquery-ui 1.8 final to be released yesterday, but I guess some blockers came up.

@robocoder
Collaborator

Sorry, no native mode fix just yet. We'll keep the IE7 compat mode and jquery 1.3.2/jquery-ui 1.7.2 libs in place for a little while longer until I have more time to investigate all the compat busters with jquery 1.4.x and jquery-ui 1.8.

When we do update the libs, we should reorganize the jquery folder a bit, relocating the uncompressed files (e.g., "original lib") and/or excluding these from the last.zip build.

@robocoder
Collaborator

(In [fixes #1062, refs #1235 - revert 1671) EmulateIE7 compatibility mode

@mattab mattab added this to the Piwik 0.6.2 milestone
@robocoder robocoder was assigned by mattab
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.