Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Internationalize the Goals plugin #1068

Closed
anonymous-piwik-user opened this Issue · 6 comments

3 participants

Anonymous Piwik user Matthieu Aubry pebosi
Anonymous Piwik user

Hi guys,

attached is a patch against trunk/0.5.1 r1660/r1661 to internationalize the Goals plugin templates. Also included is a separate patch to provide those strings in the en.php fallback translation. I hope to provide a de.php version later this week.

Dunno if I'm setting this against the right milestone, so someone retarget this to 0.6 if only bugfixes go in 0.5.x

Keywords: translation, de, en, Goals, plugin

Anonymous Piwik user

Attachment: patching goals plugin template files
internationalizing-goals-plugin.txt

Anonymous Piwik user

Attachment: patching /lang/en.php translations file
internationalizing-goals-plugin-lang.txt

Anonymous Piwik user

Attachment: Heres the update for lang/de.php
de.php.diff

Matthieu Aubry
Owner

Thanks for that! is the patch covering all the strings in the Goals plugin templates?

pebosi

Some js strings are missing, i will create an other patch to cover all strings.

regards

Matthieu Aubry
Owner

Fixed in 1929

Fixes #1068 added i18n in all existing Goal plugin strings & js strings
updated documentation to explain how to translate JS strings in plugins + how to reload a widget in dashboard (this will be available in http://dev.piwik.org/trac/wiki/Plugins/GlobalFunctions after the release)

Anonymous Piwik user anonymous-piwik-user added this to the Piwik 0.5.5 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.