Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

plugins/*/API.php - E_STRICT cleanup #1122

Closed
robocoder opened this Issue · 6 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang
Collaborator

For consistency (and to avoid E_STRICT warnings), public API functions should be declared as "static public". In many cases, it's simply "public" (or in some cases, implied).

Use of $this should be replaced with self::getInstance().

Anthon Pang
Collaborator

(In [1817]) fixes #1122

Anthon Pang
Collaborator

(In [1832]) fixes #1122 - per Matt's review

Anthon Pang
Collaborator

(In [1833]) refs #1122 - fix usage

Anthon Pang
Collaborator

(In [1834]) refs #1122 - fix core usage

Anthon Pang
Collaborator

(In [1835]) refs #1122 - fix unit test

Matthieu Aubry
Owner

Tu summarize, instead of changing all API methods to being static, we decided to change all callers to not call methods statically as this could cause various issues in the future. Thanks vipsoft!

Anthon Pang robocoder added this to the Piwik 0.5.5 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.