plugins/*/API.php - E_STRICT cleanup #1122

Closed
robocoder opened this Issue Jan 22, 2010 · 6 comments

2 participants

@robocoder

For consistency (and to avoid E_STRICT warnings), public API functions should be declared as "static public". In many cases, it's simply "public" (or in some cases, implied).

Use of $this should be replaced with self::getInstance().

@robocoder

(In [1817]) fixes #1122

@robocoder

(In [1832]) fixes #1122 - per Matt's review

@robocoder

(In [1833]) refs #1122 - fix usage

@robocoder

(In [1834]) refs #1122 - fix core usage

@robocoder

(In [1835]) refs #1122 - fix unit test

@mattab
Piwik Open Source Analytics member

Tu summarize, instead of changing all API methods to being static, we decided to change all callers to not call methods statically as this could cause various issues in the future. Thanks vipsoft!

@robocoder robocoder added this to the Piwik 0.5.5 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment