Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP


add: SitesManager getIdFromSite() #1261

anonymous-piwik-user opened this Issue · 10 comments

3 participants

Anonymous Piwik user Anthon Pang Matthieu Aubry
Anonymous Piwik user

For plugins/SitesManager/API.php, companion function to getSiteFromId()

This should search the database for a URL and return the ID of that site. This is extremely useful in keeping two databases synced (WPMU and Piwik in my case)

Matthieu says to remove the viewAccess check, but I'm only following convention from getSiteFromId(). Feel free to remove.

Sorry I don't have time to submit a proper patch.

     * Returns the website information : id
     * @exception if the site website doesn't exist or the user doesn't have access to it
     * @return string
    public function getIdFromSite( $site_url )
        $site_url = $this->removeTrailingSlash($site_url);

        $id = Zend_Registry::get('db')->fetchRow(
                    "SELECT Idsite FROM ".Piwik::prefixTable("site")." WHERE main_url = ?".
                    "UNION SELECT Idsite FROM ".Piwik::prefixTable("site_url")." WHERE url = ?", array($site_url, $site_url));

        $id = isset($id['Idsite'])?$id['Idsite']:false;

        if ($id) { Piwik::checkUserHasViewAccess( $id ); }

        return $id;
Anthon Pang

vote: stick with convention and keep the view access check.

Anonymous Piwik user

In light of being told that URLs may have multiple IDs, this should be changed to return an array:

 $id = isset($id['Idsite'])?$id['Idsite']:$id; ```

Assuming Zend_Registry::get returns multiple rows?

Also, this line:

if ($id) { Piwik::checkUserHasViewAccess( $id ); } ```

would need to iterate over the IDs array on multiple matches and make sure each had access.

Matthieu Aubry

I didn't say to remove the access check (of course!). My point was that this code is invalid because it will error out if one other websites (that you don't have access to) has the URL you are requesting. Only websites that you have permissions to view should be returned.

oooa, the Piwik::checkUserHasViewAccess function also accepts an array of IDs

did you test this code? I see it reads "Idsite" when the field name is idsite..

Anthon Pang

Instead of checkUserHasViewAccess ... can you use the array of ids returned from getSitesIdWithAtLeastViewAccess() in the WHERE clause? i.e., idsite IN (?)

Matthieu Aubry

probably, even though we want to avoid this as it doesn't scale (in the use case you have 2000 websites)

Anthon Pang

The alternative is a subquery on the access table,

WHERE idsite IN (SELECT idsite FROM access WHERE user = ?)

Anonymous Piwik user

Idsite is capitalized because the select, I guess. Code does work as-is!

Anthon Pang

AFAICS, comment:3 (comment:6 ?) and unit tests are still todo items.

Anthon Pang

(In [2061]) fixes #1261 - SitesManager: add getSitesIdFromSiteUrl( $url ) to API; add unit test

Anthon Pang

(In [2062]) refs #1261 - add unit tests for more complete test coverage

Anonymous Piwik user anonymous-piwik-user added this to the Piwik 0.6 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.