Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bing image Search #1283

Closed
anonymous-piwik-user opened this Issue · 5 comments

3 participants

Anonymous Piwik user Anthon Pang Matthieu Aubry
Anonymous Piwik user

Maybe it would be useful to add the Bing Image search to the search engines.

        // Bing Images
        'www.bing.com/images/'      => array('bing.com', 'search', 'http://www.bing.com/images/search?q={k}'

Hope it works

Anthon Pang
Collaborator

"hope it works"? Can you test it?

Anthon Pang
Collaborator

The current logic is on the domain name, excluding the path. To implement this enhancement would require changes to Piwik.php extractSearchEngineInformationFromUrl().

Marking as wontfix, but invite anyone to submit a clean patch.

Matthieu Aubry
Owner

Note that Google images is handled using a manual hack, see https://github.com/piwik/piwik/blob/master/core/Common.php#L945

Such similar hack could be used for bing images

Anthon Pang
Collaborator

Let's try to fix this at the same time as #1348

Matthieu Aubry
Owner

(In [2175]) Fixes #1283 Bing images search. I haven't tested in the UI and checked that the link to the keyword works.

Anonymous Piwik user anonymous-piwik-user added this to the Piwik 0.6.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.