Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Deprecate/remove Piwik_Quote() #1292

Closed
robocoder opened this Issue · 2 comments

1 participant

Anthon Pang
Anthon Pang
Collaborator

Not used anywhere in Piwik core because we use Zend to prepare statements. Moreover, manual for PDO::quote says:
[...] you are strongly recommended to use PDO::prepare() to prepare SQL statements with bound parameters instead of using PDO::quote() to interpolate user input into a SQL statement. Prepared statements with bound parameters are not only more portable, more convenient, immune to SQL injection, but are often much faster to execute than interpolated queries, as both the server and client side can cache a compiled form of the query.

Anthon Pang
Collaborator

(In [2054]) fixes #882 - Piwik_Query() can now be used by tracker plugins;
fixes #1292 - remove (deprecated/unused) Piwik_Quote() since we use Zend_Db for prepared statements; add Piwik_FetchRow() for completeness

Anthon Pang
Collaborator

(In [refs #1292/2054) - typo in phpdocs

Anthon Pang robocoder added this to the Piwik 0.6 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.