Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

(X)HTML elements don't have unique ids #1300

Closed
robocoder opened this Issue · 2 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang
Collaborator

The id attribute must be unique within a document. This is a problem on the Dashboard with jquery 1.4.x (and its optimized selector code).

Reference: http://www.w3.org/TR/html401/struct/global.html#h-7.5.2

Examples (non-exhaustive list):

  • <div id="emptyDatatable">
  • <div id="dataTableFeatures">
  • <span id="dataTablePages"/>
  • <span id="dataTablePrevious">
  • <span id="dataTableNext">
  • <span id="dataTableSearchPattern" ...>
  • <input id="keyword" ...>
  • <span id="dataTableFooterIcons" ...>
  • <span id="exportToFormat" ...>
  • <span id="linksExportToFormat" ...>
  • <span id="dataTableFooterIconsShow" ...>
  • <span id="tableAllColumnsSwitch" ...>
  • <span id="loadingDataTable">

See also: #950, #1235

Matthieu Aubry
Owner

I dont think we should change this now as this wouldn't change anything, plus in the feature I think it would make more sense to rewrite the datatable JS code to make it more simple (only read JSON from server and have the presentation fully in JS, rather than hacking the DOM as it is now).
vote for wontfix

Anthon Pang
Collaborator

(In [2161]) fixes #1300

Anthon Pang robocoder added this to the Piwik 0.6.2 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.