Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Visitor Log always shows all data #1319

Closed
anonymous-piwik-user opened this Issue · 14 comments

4 participants

@anonymous-piwik-user

I have discovered that the "visitor log" always shows the whole data. E.g. 30 April is selected but the table also shows data from 29 April and so on...
This behavior makes the "visitor log" very slow.

@JulienMoumne
Collaborator

I have added a patch to solve the issue.

Do tell me what you think about it.

@JulienMoumne
Collaborator

Attachment:
live.patch

@mattab
Owner

looks good to me - did you test the patch with more than 1000 visits in one day? does the visitor log load faster with the patch? (visits generator can be found in misc/generateVisits.php)

@JulienMoumne
Collaborator

After testing with a lot of data, there is a cap at 1000 visits (both before and after suggested patch).

You will see improvement if you select a day period with less than 1000 visits.

@mattab
Owner

Core review: The private method loadLastVisitorDetailsFromDatabase() signature has changed (added $period parameter) but there are other calls to this method that haven't been updated to add the new $period parameter.

@JulienMoumne
Collaborator

I have updated and tested required methods.

If you look at /plugins/Live/Controller.php there is an API call to method 'getLastVisits'. Method 'getLastVisits' has been updated to add $period and $date parameters.

I didn't know if the call at lign 133 had to be updated as well to provide period and date values. I tried to leave it as it is and also tried to provide the values. In both cases the values for period and date are provided to the API method 'getLastVisits'.

This is why I didn't update the API call.

Please advise on this matter.

@JulienMoumne
Collaborator

Attachment:
#1319.patch

@mattab
Owner

Call at line 133 builds a Piwik_Api_Request object, which will look into _GET for parameters not passed in the constructor string so this is OK.

@mattab
Owner

sorry for delay,
I applied the patch but It breaks the Live! visitors plugin (not on first load, but after few seconds and reload).

maybe some API calls haven't passed new parameters?

@JulienMoumne
Collaborator

My mistake.

When the API call is made with the jQuery spy plugin, no Date and no Period is provided to the call. The jQuery spy plugin receives the error "period parameter not provided" and breaks the widget.

I just had to specify that those parameters (date and period) are mendatory. Cf. new patch.

@JulienMoumne
Collaborator
@JulienMoumne
Collaborator

I meant "not mandatory".

@peterbo
Collaborator

Attachment: Can't we keep it simple with getting the date / period in the given method? Then we'll not make the Plugin even more complicated; Patch running without bugs in my local repository
LivePluginApiApplyDateRange.patch

@peterbo
Collaborator

(In [2784]) fixes #1375, #1319

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.