Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Adding missing search engine favicons #1350

Closed
halfdan opened this Issue · 13 comments

3 participants

Fabian Becker Anthon Pang Matthieu Aubry
Fabian Becker
Collaborator

Collecting missing search engine favicons here.
Keywords: favicon

Fabian Becker
Collaborator
Fabian Becker
Collaborator
Fabian Becker
Collaborator

Attachment:
hooseek.com.png

Anthon Pang
Collaborator

halfdan: will you be able to go through the entire list (core/DataFiles/SearchEngines.php and plugins/Referers/images/searchEngines)?

p.s. Looks like mserv.rrzn.uni-hannover.de.png is deprecated by above and can be removed.

Matthieu Aubry
Owner

we don't need to put icons from the full list, as most search engines are very rarely used, and this would increase the archive size.

Fabian Becker
Collaborator

matt: alright
vipsoft: Sure, I'd just write a script to fetch all favicons.

The icons above are just those that were missing in my/the piwik demo stats.

Anthon Pang
Collaborator

I count ~230 entries in core/DataFiles/SearchEngines.php, and ~195 files in plugins/Referers/images/searchEngines. So, about 35 missing icons. If the average icon is .5K, I think we can afford an extra 18K added to the archive size.

(BTW we can free up 464K by not including "libs/jquery/original lib" in the archive.)

Matthieu Aubry
Owner

Anthon, good point regarding "libs/jquery/original lib"; can you delete it and add in a REAMDE file what the files are (if there are special things to know about them)

Also OK I didn't realize that most icons were already in there.

Fabian Becker
Collaborator

Alright, assign me this ticket - I'll add the missing favicons.

Fabian Becker
Collaborator

Just to be sure: The favicon name is the url + .png of the first appearance of a search engine in core/DataFiles/SearchEngines.php?

In that case I have 82 new favicons and a list of 36 favicons that can be removed because of redundancy.

Fabian Becker
Collaborator

Attachment: Script to fetch missing and list not needed favicons.
ProcessFavicons.zip

Fabian Becker
Collaborator

Attachment: Favicons + List of not needed favicons
Favicons.zip

Anthon Pang
Collaborator

(In [2190]) fixes #1350 - add missing icons and remove redundant icons; contributed by halfdan; p.s. nice script

Fabian Becker halfdan added this to the Piwik 0.6.2 milestone
Fabian Becker halfdan self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.