Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix missing translations in title tag of several header.tpl #1354

Closed
hansfn opened this Issue · 5 comments

4 participants

Hans Fredrik Nordhaug Fabian Becker Matthieu Aubry Anthon Pang
Hans Fredrik Nordhaug

Line 5 of plugins/CoreAdminHome/templates/header.tpl - hard coded "Administration".

Line 5 of plugins/CoreHome/templates/header.tpl - hard coded "Web Analytics Reports".

Line 5 of plugins/Login/templates/header.tpl - hard coded "Login".

These issues are quite important since the title is a very visible thing.

Fabian Becker
Collaborator

Attachment:
patch

Fabian Becker
Collaborator

Patch fixes all three issues.

Note: I used the key Login_LogIn in en.php to translate "Login". This is currently (for some reason) set to "Sign In".

Matthieu Aubry
Owner

(In [2176]) Fixes #1354

Matthieu Aubry
Owner

I applied the patch but it wasn't working (missing single quotes) please test your patches before submitting. thx

Anthon Pang
Collaborator

(In [refs #1354, 2176)

Hans Fredrik Nordhaug hansfn added this to the Piwik 0.6.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.