Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Google Advanced Search support #1370

Closed
halfdan opened this Issue · 19 comments

4 participants

Fabian Becker Anonymous Piwik user Anthon Pang Matthieu Aubry
Fabian Becker
Collaborator

Saw the following URL in my referer list:

google.co.uk

Problem: The search parameter isn't &q=keywork but &as_q - Trying to figure out where this comes from brought me to this page. The "advanced search" from google doesn't use &q=. It is even possible to combine these parameters like:

&as_q=test1&as_epq=test2&as_oq=foo+bar+baz

My idea to include this would be to allow KeywordParameter to be an array in SearchEngines.php.


I found that "google.kg" (Kyrgyzstan) is not included in the list of search engines.

Anonymous Piwik user

that is the official list of google domains
http://www.google.com/supported_domains maybe some more are missing

Fabian Becker
Collaborator

Oh well.. ignore my suggestion. KeywordParameter already allows arrays. We should therefore adjust the setting for all Google entries to:

array(
  'q',
  'as_q',
  'as_oq',
  'as_epq'
);

hebbet: Thank for the link. Just wrote a little script to check if any other TLDs are missing. (see Attachment)

While writing the script I noticed the entry for google.fr:

'www.google.fr.' => ..

That looks like a typo to me (www.google.fr is in the list).

matt/vipsoft: Let me know if we should include the other parameters for Google in the list and I'll prepare a patch.

Fabian Becker
Collaborator
Fabian Becker
Collaborator

Attachment:
missing_list.txt

Anthon Pang
Collaborator

The problem is that these advanced query parameters (as_q=ALL_THESE_WORDS, as_epq=EXACT_WORDING, as_oq=OR1+OR2+OR3, and as_eq=UNWANTED) can all appear in the referrer URL.

halfdan: sure, a patch would be great. Don't forget to change Piwik_Common::extractSearchEngineInformationFromUrl() and please add some unit tests.

Fabian Becker
Collaborator

vipsoft: How do you think this should be handled? Should I just build a string from all keywords provided? This would lead to false reports e.g. in case of as_eq. Any suggestions?

Matthieu Aubry
Owner

no problem to add missing google URLs, please provide patch

Matthieu Aubry
Owner

Replying to vipsoft:

The problem is that these advanced query parameters (as_q=ALL_THESE_WORDS, as_epq=EXACT_WORDING, as_oq=OR1+OR2+OR3, and as_eq=UNWANTED) can all appear in the referrer URL.

I think that's fine, as long as if 'q' is found, it has priority over other variables.

Matthieu Aubry
Owner

actually it would be an issue... to solve this issue properly, we would need to be able to construct the query string from the list of possible parameters (q, as_q, as_qe, etc.) which is I believe undocumented by google, and probably undesirable considering the low traffic. I vote for won't fix..

Anthon Pang
Collaborator

Replying to matt:

I vote for won't fix..

But it would be nice-to-have. I'll reserve judgement until I've seen a patch.

Fabian Becker
Collaborator

matt: SearchEngine patch is attached.

vipsoft: I'll need to think this through. I'm not sure yet on how to visualize the combined data (e.g. as_eq=UNWANTED should not appear as "keyword" because keywords usually suggest that the page was found using that keyword and not by ignoring it).

I'm mabye postposing the patch until after 0.6.2 as I'll focus on other work first. Feel free to move the ticket to 0.8 when necessary.

Fabian Becker
Collaborator
Matthieu Aubry
Owner

as_eq=UNWANTED is equivalent, I believe, to using minus: "keyword -notThisKeyword"

Matthieu Aubry
Owner

(In [2212]) Refs #1370 adding google URLs thanks halfdan!

Anthon Pang
Collaborator

I'll keep this ticket open. In the meantime, I created #1381 to record the addition of the missing Google URLs/domains, for the upcoming 0.6.2 changelog.

Matthieu Aubry
Owner

moving it to later milestone.

Anthon Pang
Collaborator

At the same time, I propose we add some code to parse out the keywords when the referer is webcache.googleusercontent.com.

Anthon Pang
Collaborator

Opening a separate ticket for webcache.googleusercontent.com. #1692

Anthon Pang
Collaborator

(In [3118]) fixes #1370 - constructs the equivalent q= query from the advanced search parameters

Fabian Becker halfdan added this to the Piwik 1.1 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.