Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Sites Manager and Users Manager - Save Confusion #1382

Closed
robocoder opened this Issue · 10 comments

2 participants

Anthon Pang Matthieu Aubry
Anthon Pang
Collaborator

Usability issue

From Twitter:@OlegLeontiev:#bugin@piwik-oncesetTimeZoneisnoteditablethroughAdminPanel.Althoughitallowseditingactions,thechanges'renotcommited

Matthieu Aubry
Owner

could you verify this? I couldn't reproduce.

Anthon Pang
Collaborator

No, but I suspect this is because he used the big "Save" button (under Global Website Settings) instead of the clicking on the green checkmark. This is a small usability issue.

Propose we add a tooltip to the green checkmark and a "Save" button next to (or below) "Add a new website".

Anthon Pang
Collaborator

Also, noticed that you can have multiple rows in edit state, but saving applies only to that one row, and refreshes the entire page (losing any other unsaved changes).

Anthon Pang
Collaborator

(In [2219]) refs #1382 - add tooltips to ok.png and remove.png when in edit state

Matthieu Aubry
Owner

To avoid users making several changes in several websites (or users), we could make it impossible to edit two rows at once. When a row is being edited, if the user clicks on another row, a javascript popup could ask 'Do you want to save your changes in the website properties before editing another website? Yes/Cancel'.

  • Clicking Yes would make the ajax request like when the OK button is clicked.
  • Clicking Cancel would restore the website properties as it was when the page was loaded.

This wouldn't fix the issue when a user edits a website and then clicks 'Save' in another section below though. Maybe the JS popup mentioned above could be displayed anytime the user focuses the mouse outside the row being edited (ie. when clicking another row, or when changing other settings on the page).

Anthon Pang
Collaborator

If the admin menu allowed submenus, we could put these sections on separate pages, so there's never more than one Save button per page.

Can we update the table after the ajax request without refreshing the page?

Matthieu Aubry
Owner

Replying to vipsoft:

If the admin menu allowed submenus, we could put these sections on separate pages, so there's never more than one Save button per page.

Yes, maybe after v1 - even though it's nice to have more settings on the same page.

Can we update the table after the ajax request without refreshing the page?

Not currently..

Matthieu Aubry
Owner

It would be simple yet useful to have a function that sets a flag when something has been updated in the table, and then warn users that he might lose changes if he doesn't save and click away in another cell of focuses outside the table.

Matthieu Aubry
Owner

Maybe we could display a big button at the bottom left of the cell as well as on the right?

Matthieu Aubry
Owner

(In [3663]) Fixes #1382

  • now preventing editing 2 rows at once
  • adding large SAVE button below the name on the left of the table (+ Cancel link which refreshes pages)

Fixes #1980

  • simplifying admin CSS, reusing same styles as PDF, Goals and datatables
  • deleting now unused icons & styles
Anthon Pang robocoder added this to the Piwik 1.2 milestone
Matthieu Aubry mattab was assigned by robocoder
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.