Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Page URLs should not record the hash part of the URL #1388

Closed
mattab opened this Issue · 5 comments

3 participants

@mattab
Owner

See in the demo Page URLs report. Since 0.6.2, entries are linked to the actual page URL. If you click on faq/plugins/ for example, you see that the page "index" links to http://piwik.org/faq/general/#faq_52

Instead, URLs should link to the canonical URL without the hash part. The hash must be removed at Tracker time.

Note: the tracker must still receive the hash, for future uses (eg. detect campaign parameters in the hash), but the php code must discard it.

@sgiehl
Collaborator

I guess for some pages it would even make sense to display those hash parts in the Page Urls report. Most Ajax-driven websites aren't changing the url often. In most cases only the hash part changes for history. Facebook might be a good example for that. Maybe it might be the best solution to make that behaviour configurable.

@mattab
Owner

Good point Steve, I think this should be an option at the javascript level, ie.

setDisallowHashTags()

by default, we would record the hash tag, users could disable it.

@robocoder
Collaborator

I thought this looked familiar. #1180

@robocoder
Collaborator

(In [3687]) fixes #1388

@mattab
Owner

Cool, later we will want to have the setAllowAnchor, because some campaign parameters are sometimes set in the hash tag, but we can do it later (also requires change in piwik.php to discard the hash tag bit in all cases after campaign parameters were parsed)

@mattab mattab added this to the Piwik 1.2 milestone
@mattab mattab self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.