Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use UNSIGNED INT for ip #1390

Closed
robocoder opened this Issue · 3 comments

2 participants

@robocoder

In hindsight, the switch to Unsigned BIGINT (#668) won't accommodate an ipv6 address (see #1111).

Using a 32-bit INT would save 4 bytes per row in the log visit table and improve performance on 32-bit systems.

@halfdan
Collaborator

Agreed, IPv6 would need 2xBIGINT, or alternatively DECIMAL(39,0) (http://www.koopman.me/2008/04/storing-ipv6-ips-in-mysql/)
Shouldn't this problem be adressed together with #1111?

@robocoder

Truncating the unsigned bigint to unsigned int should be minimal effort and we already have unit tests for the conversion to/from dotted decimal form. #1111 requires more effort.

@robocoder

(In [2236]) fixes #1390 - use UNSIGNED INT for ip; since the upper 32 bits is unused, the ALTER statement simply truncates to the lower 32 bits

@robocoder robocoder added this to the Piwik 0.6.3 milestone
@robocoder robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.