Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fatal Error in archiver with Turkish locale #1437

Closed
anonymous-piwik-user opened this Issue · 4 comments

3 participants

Anonymous Piwik user Anthon Pang Matthieu Aubry
Anonymous Piwik user

Hi,
I'm using Piwik on a system with tr_TR.UTF-8 locale and this error shows up when running archiver:

Fatal error: Class 'Piwik_Db_Adapter_MysqlI' not found in /my_path_to_piwik/piwik/core/Db/Adapter.php on line 41

And that line is:
return 'Piwik_Db_Adapter_' . str_replace(' ', '', ucwords(str_replace('', ' ', strtolower($adapterName))));

Problem is strtolower doesn't lower MysqlI properly, it should lower to "mysqli" but in Turkish locale lower letter for "I" is "" so that makes "mysql". I think you should use a locale independent (or working only in latin1 locale) strtolower here, but I don't know what is the proper way to do that in php.

I run archiver with LC_ALL=C for a workaround and it works fine that way.

Anthon Pang
Collaborator

Interesting.

Matthieu Aubry
Owner

interesting indeed.. If strtolower fails, other logic/algorithm will fail too.
For example if we add a 'renderer' with a 'i' letter in the name, the factory will fail.

Anthon Pang
Collaborator

Ok, I was able to reproduce after I ran locale-gen (and logged out and back in).

Anthon Pang
Collaborator

(In [2327]) quick fixes #1437 - setlocale(LC_CTYPE, '') so strtolower(), strtoupper(), ucfirst(), and ucwords() aren't affected by locale

In the future, we might consider implementing a thread-safe alternative to using setlocale() given this warning:

The locale information is maintained per process, not per thread. If you are running PHP on a multithreaded server API like IIS or Apache on Windows, you may experience sudden changes in locale settings while a script is running, though the script itself never called setlocale(). This happens due to other scripts running in different threads of the same process at the same time, changing the process-wide locale using setlocale().

Reference: http://php.net/setlocale

Anonymous Piwik user anonymous-piwik-user added this to the Piwik 0.6.3 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.