Replace Html Quickform for GPL compatibility #1442

Closed
robocoder opened this Issue Jun 23, 2010 · 23 comments

2 participants

@robocoder

Follow-up to #1243: the current version of Piwik has been rejected from directory.fsf.org due to license issues:

  • license files are missing or incomplete (which we' will need to advise upstream) for some third-party components/libraries
  • the PEAR package, Html/Quickform is licensed under PHP 3.01 license and is GPL incompatible; propose we migrate to Zend_Form
@mattab
Piwik Open Source Analytics member

ok sounds good about moving to Zend_Form, but delaying

@robocoder

Matt: did you write jquery.truncate.js? That file and UserAgentParser.php are missing license notices.

@mattab
Piwik Open Source Analytics member

yes I wrote both files

@robocoder

So, MIT/GPL and LGPL, respectively?

@mattab
Piwik Open Source Analytics member

I would say both under BSD

@robocoder

(In [2369]) refs #1442 - add BSD license text

@robocoder

(In [2371]) refs #1442 - add missing license files per FSF review; remove uncompressed javascript folders; move jquery.tooltip and jquery.truncate to parent folder for consistency

@robocoder
  • As noted in ./LEGALNOTICE, jquery.spy's license is unspecified. I have requested clarification from the developer.
  • Also, the copyright holder is unspecified from swfobject , and I have similarly requested clarification.
  • An alternative to Zend_Form may be HTML_QuickForm2 which is BSD licensed, but currently in alpha state (v0.4 released earlier this month).
@robocoder

(In [2385]) refs #1442

@robocoder

(In [2388]) refs #1442 - rename Login forms for consistency with Installation forms; rename Piwik_Form to Piwik_QuickForm

@robocoder

(In [2390]) refs #1442 - consistency in constructors

@robocoder

(In [2415]) refs #1442 - update license info

@robocoder
  • Submitted request to devs to re-license HTML_QuickForm, as that would be faster/easier than switching over to Zend_Form or HTML_QuickForm2.
  • Sent another email to Remy Sharp requesting clarification on jquery spy license.
@robocoder

Not getting any love from the QF devs. Back to plan A.

@robocoder

(In [2417]) refs #1442 - another license incompatibility; the latest version of the PEAR base system is BSD licensed, so will look into updating to that...

@robocoder

(In [2418]) refs #1442 - update PEAR to latest version which is BSD licensed (and thus, GPL compatible)

@robocoder

(In [2419]) refs #1442 - add license file to PEAR and some new dependencies; add "static" keyword to isError and raiseError as this throws notices with HTML_QuickForm

@robocoder

(In [2428]) refs #1442 - discard Zend_Form -- too much overhead and rework; will port to QuickForm2

@robocoder

jquery.spy is now MIT licensed.

I'll try to finish the QF2 port tonight.

@robocoder

(In [2435]) refs #1442 - add HTML_Common2 and HTML_QuickForm2 - New BSD licensed

@robocoder

In [2437]:

Synced up with PEAR svn repository revision 301028

    * add HTML_QuickForm2_Renderer_Smarty
    * comment out require_once
    * let autoloaders try loading class first -  http://pear.php.net/bugs/bug.php?id=17568
    * HTML_QuickForm_Node -  http://pear.php.net/bugs/17557 
@robocoder

(In [2438]) fixes #1442 - all GPL license incompatibilities resolved

Live: Thanks to Remy Sharp, jquery.spy is now explicitly MIT licensed.
Installation: converted to use HTML_QuickForm2
Login: converted to use HTML_QuickForm2

@robocoder

(In [2506]) refs #1442 - fix typo in prefix

@robocoder robocoder added this to the Piwik 0.6.4 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment