Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Sorting in API without order #1456

Closed
sgiehl opened this Issue · 3 comments

2 participants

Stefan Giehl Matthieu Aubry
Stefan Giehl
Collaborator

It is nice, that it's adjustable to sort the API-responses as needed.
Is there a reason why filter_sort_column and filter_sort_order have both to be given in a request to get it sorted. I would expect that sorting a column without a given order behaves like any database and orders asc by default.

It's not realy a bug, but i just wondered why sorting didn't apply without filter_sort_order.

I guess it's easy to change this. Giving a default value for filter_sort_order in core/API/DataTableGenericFilter.php should fix it.
Keywords: API sorting order

Matthieu Aubry
Owner

sounds good, but filter_sort_order should default to 'desc' in our case

Stefan Giehl
Collaborator

(In [2481]) fixes #1456 added default sorting order (desc) if filter_sort_order is not given

Matthieu Aubry
Owner

(In [2484]) Refs #1456

Fixing failing integration tests now that Sort filter is called by default with 'desc'.

Note: to fix integration tests, compare tests/integration/processed and tests/integration/expected/ with a file compare tool (like WinMerge on windows). If it looks good, copy processed/* files over the expected/* and tests will pass.

Stefan Giehl sgiehl added this to the Piwik 0.6.4 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.