Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

File integrity check errors when files not uploaded in binary mode #1469

Closed
robocoder opened this Issue · 3 comments

1 participant

@robocoder
Collaborator

Pseudo-code:

already_reported = false
...
if (fails filelength check) {
    message = 'File length mismatch'
    if (! already_reported) {
        read file
        convert CR LF to LF
        if (md5 sum passes) {
            message = 'File length mismatch.  Please re-upload your files using BINARY mode.'
            already_reported = true
        }
    }
    messages[] = message
}
@robocoder
Collaborator

(In [2591]) fixes #1469

@robocoder
Collaborator

(In [2592]) refs #1469

@robocoder
Collaborator

(In [2622]) refs #1469 - performance improvement: check converted length vs expected, before hashing

@robocoder robocoder added this to the Piwik 0.6.4 milestone
@robocoder robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.