SitesManager.updateSite succeeds for unknown idsite #1585

anonymous-piwik-user opened this Issue Aug 14, 2010 · 5 comments

2 participants


The response for SitesManager.updateSite is wrong. Calling it with an unknown idSite parameter results in

{"result":"success", "message":"ok"}

This makes no sense - and can't IMHO not be deserved, as delteSite returns

{"result":"error", "message":"website id = 124 not found"}

on error.

Thanks for your work!


Attachment: Patch file


To may be speed it up a bit and make your life easier :) I've attached a patch, which adds the same check, which is also done in deleteSite()


Thanks, but getAllSitesId() requires superuser access. Some refactoring needs to be done.


(In [2928]) fixes #1585


(In [2977]) refs #1585, refs #1638 - merged from trunk

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment