Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

CSS3 Support for IE 8 with CSS3PIE #1625

Closed
gka opened this Issue · 26 comments

5 participants

Gregor Aisch Anthon Pang Stefan Giehl Matthieu Aubry Julien Moumné
Gregor Aisch
Collaborator

I just found the CSS3PIE project, which aims to add CSS3 support to Internet Explorer 8 (and below). I tried this demo in IE8 and it works (rounded corners, css shadow).

Maybe we can integrate this into Piwik.

Anthon Pang
Collaborator

There's diminishing value with IE9 approaching, but if CSS3PIE is compatible with jQuery/jQueryUI, and isn't noticeably slower for IE8 users, then it's fine with me.

Stefan Giehl
Collaborator

As there are many big companies still using older browsers like IE7, we should try to optimize the layout for IE. As CSS3PIE works for IE 6,7 & 8 it might be a good choice. I already tried to integrate it and it seems to be quite easy.

Anthon Pang
Collaborator

Assign the ticket so others know it's being worked on.

WRT browser support. Piwik supports older browsers (e.g., IE5 and above) in piwik.js, but for the dashboard/GUI, we only want to support newer releases otherwise the cross-browser regression testing (and maintenance for backward compatibility) becomes too burdensome. We also have to consider constraints by third-party libs (e.g., jQuery).

Stefan Giehl
Collaborator

CSS3PIE has a dual license: Apache-2 and/or GPL-2 (see http://github.com/lojjic/PIE/blob/master/LICENSE)

Are those licenses compatible with ours?

Anthon Pang
Collaborator

Fortunately, Apache 2 is compatible with GPL v3.

If it was dual licensed as Apache 2 or GPL (v2 or later), either would be fine.

Stefan Giehl
Collaborator

Ok, fine. I will try to finish a first integration this weekend. If it works stable, I will commit it to trunk, so that others can test it before merging it to the 1.0 branch.

Stefan Giehl
Collaborator

(In [3017]) refs #1625 added CSS3PIE to libs

Stefan Giehl
Collaborator

(In [3018]) fixes #1625 added use of css3pie for ie
tested in ie 7 & 8

Anthon Pang
Collaborator

(In [3019]) refs #1625 - update legal notice

Stefan Giehl
Collaborator

(In [3020]) refs #1625 do not use css3pie for '.entityTable' - seems to crash IE

Matthieu Aubry
Owner

I tried trunk in IE8 but I don't see rounded corners (calendar, website selector etc.) is it expected?

Anthon Pang
Collaborator

I'll fix that ... libs/CSS3PIE/PIE.php (a php proxy to server PIE.htc) is probably blocked by libs/.htaccess.

Julien Moumné
Collaborator

(In [3061]) PIE.htc file is now served through piwik static file proxy. See #1527 for more info.

Anthon Pang
Collaborator

Reference: http://css3pie.com/documentation/known-issues/
IE interprets the URL for the behavior property relative to the source HTML document, rather than relative to the CSS file like every other CSS property.

Is this why rounded corners only appears when the AssetManager is enabled?

Julien Moumné
Collaborator

With ./libs/CSS3PIE/PIE.php, CSS3PIE works with AssetManager enabled and disabled.

I've been looking for a fix but I'm not even able to make it work like it used to, ie. with AssetManager enabled and using:

behavior: url("./index.php?module=CoreHome&action=getPieHtc")

I tried several ways to declare the file :

./index.php, /index.php, index.php, ../../index.php

I looked at any modifications made to Piwik::serveStaticFile() and couldn't find anything that would help me understand.

Anthon Pang
Collaborator

Strange indeed. I'll reopen for investigation.

Anthon Pang
Collaborator

(In [3157]) fixes #1625 - tested with assetmanger enabled and disabled

Anthon Pang
Collaborator

Sorry, there are some unrelated changes in that commit. I tried to Ctrl-C that but was too late to abort the commit.

Anthon Pang
Collaborator

[3158] reverts the last set of changes

Anthon Pang
Collaborator

(In [3159]) refs #1625 - marking as fix; anomalies appear to be an internal cache issue with IE

Matthieu Aubry
Owner

I am using IE8, but I don't see any UI changes (rounded corners, etc.) after the changes in this ticket. Do you see any changes in IE8?

Anthon Pang
Collaborator

This would be the cache "anomaly". Clearing the browser cache and restarting the browser helps. Make sure IE isn't in compatibility mode.

Matthieu Aubry
Owner

Cool, after fixing #1822 I now see the rounded corners in IE.
This CSSPIE library is very intriguing black magic :)

Matthieu Aubry
Owner

I just tried on the demo.piwik.org, with IE8, and I see a Javascript error message in PieHtc:

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Timestamp: Tue, 15 Feb 2011 02:49:38 UTC

Message: 'I.f().images' is null or not an object
Line: 54
Char: 44
Code: 0
URI: t

To replicate, go to dashboard, Add a widget, and hover over the items

Anthon Pang
Collaborator

(In [3915]) refs #1625 - update to CSS3PIE 1.0beta3

Matthieu Aubry
Owner

It looks like it fixed it, no more errors in IE. thanks vipsoft!

Gregor Aisch gka added this to the Piwik 1.2 milestone
Stefan Giehl sgiehl was assigned by gka
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.