Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

jQuery - Live Visitors Widget memory leak #1662

Closed
anonymous-piwik-user opened this Issue · 6 comments

4 participants

Anonymous Piwik user Stefan Giehl Anthon Pang Matthieu Aubry
Anonymous Piwik user

Hi

I have noticed that after having the Piwik dashboard with the Live Visitors widget embedded open for a while, Firefox (and also Chrome) becomes really sluggish.

I've attached a heap dump (from Chrome) ... +235MB image data in quarter an hour is quite bad. I would assume that entries, that are no longer displayed in the widget are not destroyed correctly.

All the best

wirtsi

Stefan Giehl
Collaborator

Well, there are 3 request sent every 8 seconds even if the further requests are still pending. That may cause the browser to overload with pending requests if server is a bit slow.

We should try to reduce the requests to only one if possible. Also new requests should only be send if latest requests are finished (or they should be aborted).

Anthon Pang
Collaborator

(In [3253]) refs #1662 - add appendTo setting so we can attach spy to the #content div; previously it would attach to the <body> and continue to run in the background after the widget was no longer present

Matthieu Aubry
Owner

As mentioned by SteveG, Currently, the Live! plugin will start 3 more ajax requests every N seconds. If the previous requests are not done, this will cause some very large requests queuing, eventually crashing the browser and causing load on the Piwik server.

New ajax requests should not be started before the 3 previous ones have returned.

Anthon Pang
Collaborator

Looking at spy.js, it looks like it guards against starting requests while there's an outstanding request.

I'm retargeting as this is appears to be a bug in jQuery ajax (see http://bugs.jquery.com/ticket/6242), not fixed in the latest version, jQuery 1.4.4.

Matthieu Aubry
Owner

Fixed in r3624

Anonymous Piwik user anonymous-piwik-user added this to the Piwik 1.1.1 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.