Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Support for webcache.googleusercontent.com #1692

Closed
robocoder opened this Issue · 2 comments

1 participant

Anthon Pang
Anthon Pang
Collaborator

There are two considerations here:

  1. when the user clicks on a search result link, he/she is viewing a cached copy of your web page; if the Piwik tracking code is on this page, then Piwik tracks a mangled looking URL
    • we should parse out the original URL and record that instead
  2. the search phrase is embedded in a parameter and has to be parsed out

Pseudo breakdown:

!http://webcache.googleusercontent.com
/search?q=cache:CD2SncROLs4J:piwik.org/blog/2010/04/piwik-0-6-security-advisory/
+piwik+security
&cd=1&hl=en&ct=clnk
Anthon Pang
Collaborator

(In [3119]) refs #1692 - recognize webcache.googleusercontent.com as a search engine

Anthon Pang
Collaborator

(In [3120]) fixes #1692 - added Piwik_Common::getUrlRequestVar() -- it is a wrapper around Piwik_Common::getRequestVar("url") and where we apply fix-ups, e.g., for the webcache URL

Anthon Pang robocoder added this to the Piwik 1.1 milestone
Anthon Pang robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.