Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

piwik.js: refactoring trackGoal, trackPageView, and trackLink #1751

Closed
robocoder opened this Issue · 5 comments

2 participants

@robocoder

trackGoal and trackPageView both send page view and browser settings. Since it's conceivable that both might be called on the same page, we can optimize piwik.js to only send the payload once per page.

Propose: send the payload once for trackPageView(), trackGoal(), and trackLink(), unless setCustomUrl() or setReferrerUrl() are called. As a side effect, this should allow for additional refactoring that reduces the size of piwik.js.

@robocoder

(In [3224]) fixes #1751

@robocoder

(In [3238]) fixes #1751 - always includes page info and browser settings in payload in case of race conditions (erring on the side of caution)

@mattab
Owner

so nothing really happened in this ticket correct? shall we close it as 'wontfix' ?

@robocoder

there were changes...just not as I originally proposed, ie previously only trackpageview and trackgoal would attach the browser settings payload; now, tracklink does too

and there was refactoring for consistency (thus smaller piwik.js)

@mattab
Owner

sounds good!

@robocoder robocoder added this to the Piwik 1.1 milestone
@robocoder robocoder self-assigned this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.