Currently, piwik explicitely forbid use of "@" in a user login. (only [a-zA-Z0-9-._] are allowed )
It doesn't make much sense to forbid the "@" and it make it impossible to integrate piwik with any service where the login is the email (such as lot of LDAP setup).
Fixing this bug is really easy :
core/Piwik.php, line 1595
&& (preg_match('/^[A-Za-z0-9_.-]*$/', $userLogin) > 0))
&& (preg_match('/^[@A-Za-z0-9_.-]*$/', $userLogin) > 0))
(I've tested it and it works great)
re: LDAP. Is this change necessary, given the LDAP plugin in #734?
I guess it is because it looks like the http_auth plugin is more interesting anyway. Ldap is only use to do authentification, piwik still do the authorization.
Comments in the bug related to the http_auth plugin seems to think the same;-)
increasing priority, as it makes sense to allow @ in logins
(In ) Fixes #1762
(In ) refs #1762 - fix unit test
(In ) fixes #1970, refs #1762 - add more unit tests