Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use ZipArchive when available #1814

Closed
robocoder opened this Issue · 4 comments

2 participants

@robocoder
Collaborator

We should use the native 'zip' extension when available (instead of PclZip) because it's faster.

See WordPress wp-admin/includes/file.php unzip_file() wrapper, and _unzip_file_ziparchive() implementation.

@robocoder
Collaborator

(In [3312]) fixes #1814

@robocoder
Collaborator

(In [3313]) refs #1814 - add another test to make sure the factory method works

@mattab
Owner

Anthon, can you please confirm that both use cases have been tested with auto update? is the new auto-update webtest covering one use case already maybe?

@robocoder
Collaborator

Unit tests cover the actual unzipping for both implementations.
Webtest covers the high level use case, as the underlying implementation has been abstracted.

@robocoder robocoder added this to the Piwik 1.1 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.