Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

API methods: format_limit vs limit inconsistency #1832

Closed
robocoder opened this Issue · 4 comments

2 participants

@robocoder
Collaborator

There are API methods in Live and SitesManager that take 'limit" instead of 'format_limit'.

Propose:

  • change these methods to instead accept format_limit; we can getRequestVar('limit') for backward compatibility
@robocoder
Collaborator

On second thought, format_limit doesn't appear in any other method signatures, and it would be a compat buster to simply remove 'limit' from the parameter list.

@robocoder
Collaborator

(In [3363]) fixes #1706, refs #1832 - allow filter_limit to override default limit; provides API consistency

@robocoder
Collaborator

(In [3380]) refs #1706, refs #1832

@mattab
Owner

(In [3479]) Fixes #1832, Fixes #1873

@robocoder robocoder added this to the Piwik 1.1 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.