Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Handle X-Forwarded-For misconfiguration #1920

Closed
robocoder opened this Issue · 1 comment

1 participant

@robocoder
Collaborator

On the PHP side, we might see:

$_SERVER['HTTP_X_FORWARDED_FOR'] contains "A.B.C.D, E.F.G.H"
while
$_SERVER['REMOTE_ADDR'] also contains "E.F.G.H".

Propose: modify getLastElementFromList() to skip over IP that duplicates REMOTE_ADDR.

@robocoder
Collaborator

(In [3547]) fixes #1920 - also removes deprecated getFirstElementFromList (formerly getFirstIpFromList)

@robocoder robocoder added this to the Piwik 1.1 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.