Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Detect output compression conflict #1940

Closed
robocoder opened this Issue · 4 comments

2 participants

@robocoder

Check for non-empty settings that likely conflict. Examples:

output_handler = ob_gzhandler

or

auto_append_file = gzip_end.php
auto_prepend_file = gzip_start.php

In these cases, we should set: disable_merged_assets = 1 or add a new setting to disable only the compression aspect (given that serveStaticFile is also used by the piwik.* proxy).

@mattab
Owner

we should only disable compression if possible, rather than disabling merged assets.

@mattab
Owner

Could this be detected by a simple ini_get ?

@robocoder

Yes, if any of the above settings are non-empty, disable compression. We can do this at runtime.

auto_append_file/auto_prepend_file - those are user-defined files (for the example, I used a user's config)

output_handler could be ob_gzhandler, ob_deflatehandler, ob_inflatehandler, ob_iconv_handler, ob_tidyhandler, mb_output_handler, ...

@robocoder

(In [3630]) fixes #1940 - runtime detection for possible conflict

@robocoder robocoder added this to the Piwik 1.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.