Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Installation: improve "Re-use existing tables" #2046

Closed
robocoder opened this Issue · 2 comments

1 participant

Anthon Pang
Anthon Pang
Collaborator

The "condition" to display the "Re-use existing tables" depends on a hard-coded number of expected core tables. This leads to a number of use cases and problems:

  1. user overwrites installation with a newer Piwik version that has added more core tables
    • if the user chooses to re-use, Piwik doesn't create the missing tables
    • if we don't increment this number, the user may be presented with an option that won't work
    • if the site table wasn't previously created (e.g., previously failed installation), user gets
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'idsite' in 'field list'
  1. dev installs Piwik and tries to run the unit tests without first configuring the ![database_tests] section
    • tables defined in ![database] section may be unexpectedly deleted
Anthon Pang
Collaborator

On second thought, creating the missing tables isn't really adviseable as there may have been other schema changes (between the current db version and the installed version of the software). Exercise caution when advising people to delete config.ini.php, and re-run the installer to regenerate config.ini.php.

Anthon Pang
Collaborator

(In [3811]) fixes #2046 - increase base table count; fix spurious table deletion

Anthon Pang robocoder added this to the Piwik 1.2 milestone
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.